You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Tommaso Teofili (Created) (JIRA)" <ji...@apache.org> on 2011/10/06 07:30:30 UTC
[jira] [Created] (HAMA-447) Apply analysis tools in order to
optimize code
Apply analysis tools in order to optimize code
----------------------------------------------
Key: HAMA-447
URL: https://issues.apache.org/jira/browse/HAMA-447
Project: Hama
Issue Type: Improvement
Affects Versions: 0.3.0
Reporter: Tommaso Teofili
Priority: Minor
Fix For: 0.4.0
Running code analysis tools (like Findbugs) there are lots of parts where our code could be slightly improved, applying such small improvements could help us on better Hama performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-447) Apply analysis tools in order to
optimize code
Posted by "Tommaso Teofili (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121785#comment-13121785 ]
Tommaso Teofili commented on HAMA-447:
--------------------------------------
Agreed, I will check and update the Jenkins builds to add it.
Also it'd be good if someone could try this patch in a high load scenario to see if it brings the desired performance improvements.
> Apply analysis tools in order to optimize code
> ----------------------------------------------
>
> Key: HAMA-447
> URL: https://issues.apache.org/jira/browse/HAMA-447
> Project: Hama
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Tommaso Teofili
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: hama-447.patch
>
>
> Running code analysis tools (like Findbugs) there are lots of parts where our code could be slightly improved, applying such small improvements could help us on better Hama performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-447) Apply analysis tools in order to
optimize code
Posted by "Thomas Jungblut (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Jungblut updated HAMA-447:
---------------------------------
Affects Version/s: (was: 0.4.0)
(was: 0.3.0)
Fix Version/s: (was: 0.5.0)
> Apply analysis tools in order to optimize code
> ----------------------------------------------
>
> Key: HAMA-447
> URL: https://issues.apache.org/jira/browse/HAMA-447
> Project: Hama
> Issue Type: Improvement
> Reporter: Tommaso Teofili
> Priority: Minor
> Attachments: hama-447.patch
>
>
> Running code analysis tools (like Findbugs) there are lots of parts where our code could be slightly improved, applying such small improvements could help us on better Hama performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-447) Apply analysis tools in order to
optimize code
Posted by "Edward J. Yoon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122492#comment-13122492 ]
Edward J. Yoon commented on HAMA-447:
-------------------------------------
{code}
- private long startTime = 0;
-
// The 'next' usable taskid of this tip
int nextTaskId = 0;
@@ -133,7 +128,7 @@
* Return the start time
*/
public long getStartTime() {
- return startTime;
+ return 0l;
}
{code}
We have to initial startTime when task is initialized, instead of hard-coded value. I'll update patch with latest changes I made.
> Apply analysis tools in order to optimize code
> ----------------------------------------------
>
> Key: HAMA-447
> URL: https://issues.apache.org/jira/browse/HAMA-447
> Project: Hama
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Tommaso Teofili
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: hama-447.patch
>
>
> Running code analysis tools (like Findbugs) there are lots of parts where our code could be slightly improved, applying such small improvements could help us on better Hama performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-447) Apply analysis tools in order to
optimize code
Posted by "Edward J. Yoon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121799#comment-13121799 ]
Edward J. Yoon commented on HAMA-447:
-------------------------------------
+1 I can test tomorrow!
> Apply analysis tools in order to optimize code
> ----------------------------------------------
>
> Key: HAMA-447
> URL: https://issues.apache.org/jira/browse/HAMA-447
> Project: Hama
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Tommaso Teofili
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: hama-447.patch
>
>
> Running code analysis tools (like Findbugs) there are lots of parts where our code could be slightly improved, applying such small improvements could help us on better Hama performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-447) Apply analysis tools in order to
optimize code
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152693#comment-13152693 ]
Hudson commented on HAMA-447:
-----------------------------
Integrated in Hama-Nightly #356 (See [https://builds.apache.org/job/Hama-Nightly/356/])
[HAMA-447] - added javadoc and AL header for PiEstimatorTest
[HAMA-447] - start adding tests to hama-examples
tommaso :
Files :
* /incubator/hama/trunk/examples/src/test/java/org/apache/hama/examples/PiEstimatorTest.java
tommaso :
Files :
* /incubator/hama/trunk/examples/pom.xml
* /incubator/hama/trunk/examples/src/test
* /incubator/hama/trunk/examples/src/test/java
* /incubator/hama/trunk/examples/src/test/java/org
* /incubator/hama/trunk/examples/src/test/java/org/apache
* /incubator/hama/trunk/examples/src/test/java/org/apache/hama
* /incubator/hama/trunk/examples/src/test/java/org/apache/hama/examples
* /incubator/hama/trunk/examples/src/test/java/org/apache/hama/examples/PiEstimatorTest.java
> Apply analysis tools in order to optimize code
> ----------------------------------------------
>
> Key: HAMA-447
> URL: https://issues.apache.org/jira/browse/HAMA-447
> Project: Hama
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Tommaso Teofili
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: hama-447.patch
>
>
> Running code analysis tools (like Findbugs) there are lots of parts where our code could be slightly improved, applying such small improvements could help us on better Hama performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-447) Apply analysis tools in order to
optimize code
Posted by "Thomas Jungblut (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121772#comment-13121772 ]
Thomas Jungblut commented on HAMA-447:
--------------------------------------
Cool, looks like good improvements, thank you.
What about running Findbugs again within the Jenkins build?
I remember we had this months ago.
> Apply analysis tools in order to optimize code
> ----------------------------------------------
>
> Key: HAMA-447
> URL: https://issues.apache.org/jira/browse/HAMA-447
> Project: Hama
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Tommaso Teofili
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: hama-447.patch
>
>
> Running code analysis tools (like Findbugs) there are lots of parts where our code could be slightly improved, applying such small improvements could help us on better Hama performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-447) Apply analysis tools in order to
optimize code
Posted by "Thomas Jungblut (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Jungblut updated HAMA-447:
---------------------------------
Affects Version/s: 0.4.0
Fix Version/s: (was: 0.4.0)
0.5.0
I schedule this to 0.5.0 as ongoing efford which must not be included in 0.4.0
> Apply analysis tools in order to optimize code
> ----------------------------------------------
>
> Key: HAMA-447
> URL: https://issues.apache.org/jira/browse/HAMA-447
> Project: Hama
> Issue Type: Improvement
> Affects Versions: 0.3.0, 0.4.0
> Reporter: Tommaso Teofili
> Priority: Minor
> Fix For: 0.5.0
>
> Attachments: hama-447.patch
>
>
> Running code analysis tools (like Findbugs) there are lots of parts where our code could be slightly improved, applying such small improvements could help us on better Hama performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-447) Apply analysis tools in order to
optimize code
Posted by "Tommaso Teofili (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tommaso Teofili updated HAMA-447:
---------------------------------
Attachment: hama-447.patch
> Apply analysis tools in order to optimize code
> ----------------------------------------------
>
> Key: HAMA-447
> URL: https://issues.apache.org/jira/browse/HAMA-447
> Project: Hama
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Tommaso Teofili
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: hama-447.patch
>
>
> Running code analysis tools (like Findbugs) there are lots of parts where our code could be slightly improved, applying such small improvements could help us on better Hama performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira