[GitHub] [iceberg] szlta commented on a diff in pull request #4868: Uniform partition field names generation

[GitBox <gi...@apache.org>]

szlta commented on code in PR #4868:
URL: https://github.com/apache/iceberg/pull/4868#discussion_r882641717


##########
api/src/main/java/org/apache/iceberg/transforms/PartitionSpecVisitor.java:
##########
@@ -86,6 +86,10 @@ default T alwaysNull(int fieldId, String sourceName, int sourceId) {
     throw new UnsupportedOperationException("Void transform is not supported");
   }
 
+  default T alwaysNull(String sourceName, int sourceId) {
+    throw new UnsupportedOperationException("Void transform is not supported");

Review Comment:
   Nope this was meant to be intentional. Each method here has a pair that doesn't take a `int fieldId`, and this was missing for the `alwaysNull` method.
   I believe this is actually the void transform, which other method should it be if not this one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org