You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2012/11/07 11:43:13 UTC
[jira] [Created] (OAK-428) Binaries might get removed by garbage
collection while still referenced
Michael Dürig created OAK-428:
---------------------------------
Summary: Binaries might get removed by garbage collection while still referenced
Key: OAK-428
URL: https://issues.apache.org/jira/browse/OAK-428
Project: Jackrabbit Oak
Issue Type: Bug
Components: core
Reporter: Michael Dürig
The [Microkernel contract|http://svn.apache.org/repos/asf/jackrabbit/oak/trunk/oak-mk-api/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java] specifies a specific format for references to binaries: ":blobId:<blobId>". Currently oak-core uses a different format and thus risks premature garbage collection of such binaries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OAK-428) Binaries might get removed by
garbage collection while still referenced
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493228#comment-13493228 ]
Michael Dürig edited comment on OAK-428 at 11/8/12 2:46 PM:
------------------------------------------------------------
This patch changes the prefix from "bin:" to ":blobId". All test cases pass. However I suspect {{PrefixContentIndex}} is now broken for binary properties.
[~tmueller], [~alexparvulescu] could you check and add a test case before we proceed with the patch?
was (Author: mduerig):
This patch changes the prefix from "bin:" to ":blobId". All test cases pass. However I suspect {{PrefixContentIndex}} is now broken for binary properties.
> Binaries might get removed by garbage collection while still referenced
> -----------------------------------------------------------------------
>
> Key: OAK-428
> URL: https://issues.apache.org/jira/browse/OAK-428
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Michael Dürig
> Attachments: OAK-428.patch
>
>
> The [Microkernel contract|http://svn.apache.org/repos/asf/jackrabbit/oak/trunk/oak-mk-api/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java] specifies a specific format for references to binaries: ":blobId:<blobId>". Currently oak-core uses a different format and thus risks premature garbage collection of such binaries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OAK-428) Binaries might get removed by garbage
collection while still referenced
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig resolved OAK-428.
-------------------------------
Resolution: Fixed
Fix Version/s: 0.6
Assignee: Michael Dürig
Fixed at revision 1408693
> Binaries might get removed by garbage collection while still referenced
> -----------------------------------------------------------------------
>
> Key: OAK-428
> URL: https://issues.apache.org/jira/browse/OAK-428
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Fix For: 0.6
>
> Attachments: OAK-428.patch
>
>
> The [Microkernel contract|http://svn.apache.org/repos/asf/jackrabbit/oak/trunk/oak-mk-api/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java] specifies a specific format for references to binaries: ":blobId:<blobId>". Currently oak-core uses a different format and thus risks premature garbage collection of such binaries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-428) Binaries might get removed by garbage
collection while still referenced
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495252#comment-13495252 ]
Thomas Mueller commented on OAK-428:
------------------------------------
Thanks!
(Just to avoid confusion) I think the new prefix is ":blobId:" not ":blobId".
The patch seems to contain a large IntelliJ specific header. I guess I can ignore it?
The PrefixContentIndex will most likely anyway have to be re-written (to use the oak-core classes and not the MicroKernel API), so I don't worry too much about it at the moment, but thanks for the heads-up.
> Binaries might get removed by garbage collection while still referenced
> -----------------------------------------------------------------------
>
> Key: OAK-428
> URL: https://issues.apache.org/jira/browse/OAK-428
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Michael Dürig
> Attachments: OAK-428.patch
>
>
> The [Microkernel contract|http://svn.apache.org/repos/asf/jackrabbit/oak/trunk/oak-mk-api/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java] specifies a specific format for references to binaries: ":blobId:<blobId>". Currently oak-core uses a different format and thus risks premature garbage collection of such binaries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-428) Binaries might get removed by garbage
collection while still referenced
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493226#comment-13493226 ]
Michael Dürig commented on OAK-428:
-----------------------------------
Using ":blobId:" instead of "bin:" to prefix binaries leads to special casing in how the type codes are interpreted. Worse, it might break {{PrefixContentIndex}} wrt. to the changes from OAK-182.
> Binaries might get removed by garbage collection while still referenced
> -----------------------------------------------------------------------
>
> Key: OAK-428
> URL: https://issues.apache.org/jira/browse/OAK-428
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Michael Dürig
>
> The [Microkernel contract|http://svn.apache.org/repos/asf/jackrabbit/oak/trunk/oak-mk-api/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java] specifies a specific format for references to binaries: ":blobId:<blobId>". Currently oak-core uses a different format and thus risks premature garbage collection of such binaries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OAK-428) Binaries might get removed by garbage
collection while still referenced
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig updated OAK-428:
------------------------------
Attachment: OAK-428.patch
This patch changes the prefix from "bin:" to ":blobId". All test cases pass. However I suspect {{PrefixContentIndex}} is now broken for binary properties.
> Binaries might get removed by garbage collection while still referenced
> -----------------------------------------------------------------------
>
> Key: OAK-428
> URL: https://issues.apache.org/jira/browse/OAK-428
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Michael Dürig
> Attachments: OAK-428.patch
>
>
> The [Microkernel contract|http://svn.apache.org/repos/asf/jackrabbit/oak/trunk/oak-mk-api/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java] specifies a specific format for references to binaries: ":blobId:<blobId>". Currently oak-core uses a different format and thus risks premature garbage collection of such binaries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-428) Binaries might get removed by garbage
collection while still referenced
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496134#comment-13496134 ]
Michael Dürig commented on OAK-428:
-----------------------------------
Ok, so I'll apply the patch then.
> Binaries might get removed by garbage collection while still referenced
> -----------------------------------------------------------------------
>
> Key: OAK-428
> URL: https://issues.apache.org/jira/browse/OAK-428
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Michael Dürig
> Attachments: OAK-428.patch
>
>
> The [Microkernel contract|http://svn.apache.org/repos/asf/jackrabbit/oak/trunk/oak-mk-api/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java] specifies a specific format for references to binaries: ":blobId:<blobId>". Currently oak-core uses a different format and thus risks premature garbage collection of such binaries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira