You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangyum <gi...@git.apache.org> on 2017/11/06 12:16:00 UTC

[GitHub] spark pull request #19670: [SPARK-22454][CORE] ExternalShuffleClient.close()...

GitHub user wangyum opened a pull request:

    https://github.com/apache/spark/pull/19670

    [SPARK-22454][CORE] ExternalShuffleClient.close() should check clientFactory null

    ## What changes were proposed in this pull request?
    
    `ExternalShuffleClient.close()` should check `clientFactory` null. otherwise it will throw NPE sometimes:
    ```
    17/11/06 20:08:05 ERROR Utils: Uncaught exception in thread main
    java.lang.NullPointerException
    	at org.apache.spark.network.shuffle.ExternalShuffleClient.close(ExternalShuffleClient.java:152)
    	at org.apache.spark.storage.BlockManager.stop(BlockManager.scala:1407)
    	at org.apache.spark.SparkEnv.stop(SparkEnv.scala:89)
    	at org.apache.spark.SparkContext$$anonfun$stop$11.apply$mcV$sp(SparkContext.scala:1849)
    ```
    
    ## How was this patch tested?
    manual tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangyum/spark SPARK-22454

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19670
    
----
commit fba4c8a7c5a343ffc1693de8994099a2aeecbd43
Author: Yuming Wang <wg...@gmail.com>
Date:   2017-11-06T12:12:00Z

    ExternalShuffleClient.close() should check null

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19670: [SPARK-22454][CORE] ExternalShuffleClient.close() should...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19670
  
    **[Test build #83485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83485/testReport)** for PR 19670 at commit [`fba4c8a`](https://github.com/apache/spark/commit/fba4c8a7c5a343ffc1693de8994099a2aeecbd43).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19670: [SPARK-22454][CORE] ExternalShuffleClient.close() should...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19670
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19670: [SPARK-22454][CORE] ExternalShuffleClient.close() should...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19670
  
    **[Test build #3982 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3982/testReport)** for PR 19670 at commit [`fba4c8a`](https://github.com/apache/spark/commit/fba4c8a7c5a343ffc1693de8994099a2aeecbd43).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19670: [SPARK-22454][CORE] ExternalShuffleClient.close() should...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19670
  
    Merged to master


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19670: [SPARK-22454][CORE] ExternalShuffleClient.close() should...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19670
  
    **[Test build #3982 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3982/testReport)** for PR 19670 at commit [`fba4c8a`](https://github.com/apache/spark/commit/fba4c8a7c5a343ffc1693de8994099a2aeecbd43).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19670: [SPARK-22454][CORE] ExternalShuffleClient.close() should...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19670
  
    **[Test build #83485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83485/testReport)** for PR 19670 at commit [`fba4c8a`](https://github.com/apache/spark/commit/fba4c8a7c5a343ffc1693de8994099a2aeecbd43).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19670: [SPARK-22454][CORE] ExternalShuffleClient.close() should...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19670
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83485/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19670: [SPARK-22454][CORE] ExternalShuffleClient.close()...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/19670


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org