DO NOT REPLY [Bug 13370] New: - [sql] DDL for INTEGER data type incorrect

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13370>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13370

[sql] DDL for INTEGER data type incorrect

           Summary: [sql] DDL for INTEGER data type incorrect
           Product: Commons
           Version: Nightly Builds
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Sandbox
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: Joe@Germuska.com


SqlBuilder includes a size parameter when generating DDL for columns of type 
INTEGER.  For Oracle 8.1.7, at least, DDL including a size for INTEGER is considered an 
error.  I can't quite tell if that's ANSI, although from Oracle's doc, it looks as if it is, which 
means that the size value should be suppressed in the SqlBuilder method 
createColumn(Column column).

I'm not providing a patch because I'm not sure whether this should be done to SqlBuilder 
or whether the method should be overridden just for OracleBuilder, but I can report that 
when I removed the size parameters, Oracle accepted my DDL.

Examples:
    CTHPRTY INTEGER (3) NOT NULL 
(generated by SqlBuilder, fails)
    CTHPRTY INTEGER NOT NULL 
(modified by me, succeeds)

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>