You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by James Cheng <wu...@gmail.com> on 2020/12/03 01:59:18 UTC
Re: Can I get a review for a documentation update (KAFKA-10473)?
Hi,
Can I get a review for this small documentation update?
Thanks,
-James
> On Oct 9, 2020, at 5:23 PM, James Cheng <wu...@gmail.com> wrote:
>
> Hi,
>
> Would someone be able to review this pull request for me?
>
> This is a small documentation change.
>
> Thanks,
> -James
>
>> On Sep 24, 2020, at 11:53 PM, James Cheng <wushujames@gmail.com <ma...@gmail.com>> wrote:
>>
>> Hi,
>>
>> Can I get a review from one of the commiters for this documentation update?
>>
>> I am adding docs for the following JMX metrics:
>> kafka.log,type=Log,name=Size
>> kafka.log,type=Log,name=NumLogSegments
>> kafka.log,type=Log,name=LogStartOffset
>> kafka.log,type=Log,name=LogEndOffset
>>
>>
>> https://issues.apache.org/jira/browse/KAFKA-10473 <https://issues.apache.org/jira/browse/KAFKA-10473>
>> https://github.com/apache/kafka/pull/9276 <https://github.com/apache/kafka/pull/9276>
>>
>> The pull request page lists lots of failed checks. However, this pull request only modifies an HTML file, and the test failures don't seem related to my changes.
>>
>> Thanks,
>> -James
>>
>
Re: Can I get a review for a documentation update (KAFKA-10473)?
Posted by Guozhang Wang <wa...@gmail.com>.
Hello James,
I will take a look at your PR. Thanks for the contribution!
Guozhang
On Wed, Dec 2, 2020 at 5:59 PM James Cheng <wu...@gmail.com> wrote:
> Hi,
>
> Can I get a review for this small documentation update?
>
> Thanks,
> -James
>
> > On Oct 9, 2020, at 5:23 PM, James Cheng <wu...@gmail.com> wrote:
> >
> > Hi,
> >
> > Would someone be able to review this pull request for me?
> >
> > This is a small documentation change.
> >
> > Thanks,
> > -James
> >
> >> On Sep 24, 2020, at 11:53 PM, James Cheng <wushujames@gmail.com
> <ma...@gmail.com>> wrote:
> >>
> >> Hi,
> >>
> >> Can I get a review from one of the commiters for this documentation
> update?
> >>
> >> I am adding docs for the following JMX metrics:
> >> kafka.log,type=Log,name=Size
> >> kafka.log,type=Log,name=NumLogSegments
> >> kafka.log,type=Log,name=LogStartOffset
> >> kafka.log,type=Log,name=LogEndOffset
> >>
> >>
> >> https://issues.apache.org/jira/browse/KAFKA-10473 <
> https://issues.apache.org/jira/browse/KAFKA-10473>
> >> https://github.com/apache/kafka/pull/9276 <
> https://github.com/apache/kafka/pull/9276>
> >>
> >> The pull request page lists lots of failed checks. However, this pull
> request only modifies an HTML file, and the test failures don't seem
> related to my changes.
> >>
> >> Thanks,
> >> -James
> >>
> >
>
>
--
-- Guozhang