You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/07/29 17:48:28 UTC

[GitHub] [pinot] jugomezv commented on a diff in pull request #9131: Add support for arrayConcatLong, arrayConcatFloat, arrayConcatDouble

jugomezv commented on code in PR #9131:
URL: https://github.com/apache/pinot/pull/9131#discussion_r933494567


##########
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/ScalarTransformFunctionWrapperTest.java:
##########
@@ -802,6 +802,57 @@ public void testArrayConcatIntTransformFunction() {
     testTransformFunctionMV(transformFunction, expectedValues);
   }
 
+  @Test

Review Comment:
   Sidd:
   
   Sure this is a good idea, just to confirm: such tests do not exists for the currently supported functions like arrayConcatInt and arrayConcatString, right? 
   
   If that is the case I can look into adding these tests for the new functions being added in this PR, I can file a new issue to support those that were added earlier so we don't hold this on earlier tech debt. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org