[jira] Reopened: (QPID-1148) c++ broker: need abstraction layer for flock and lockf posix calls.

["Steve Huston (JIRA)" <qp...@incubator.apache.org>]

     [ https://issues.apache.org/jira/browse/QPID-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Huston reopened QPID-1148:
--------------------------------


I'm requesting some additional review on this issue with respect to changes made during the Windows port. This was discussed with Andrew Stitcher as well via email, so he may want to weigh in.

Basically, the idea here (lockfile.diff patch attached) is to stop including a platform-specific header from the qpid/sys level, instead using a platform-private class to hold platform details and the sys-level LockFile class refers to the private class.

Additionally, this adds readPid() and writePid() methods to handle the pid as used in the broker. qpid/broker/Daemon.cpp change to use that is included in the patch as well.


> c++ broker: need abstraction layer for flock and lockf posix calls.
> -------------------------------------------------------------------
>
>                 Key: QPID-1148
>                 URL: https://issues.apache.org/jira/browse/QPID-1148
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>         Attachments: lockfile.diff
>
>
> The broker code uses posix calls lockf and flock for file locking. These calls need to be moved to abstraction classes in qpid::sys so that porting work (in particular to windows) can replace the implementations without having to refactor top-level broker code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.