You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/23 20:23:08 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request #2778: Restore original format of m2:/ URLs modified by aa256463dcefb3b95bec6b7ac74e04a960015bc9
matthiasblaesing opened a new pull request #2778:
URL: https://github.com/apache/netbeans/pull/2778
m2:/ became a defacto API for the autoupdate mechanism. Both OpenJFX and
nb-javac rely on being able to be downloaded via the ".external" files
mechanism and third party modules could also rely on the exact syntax
of the URLs.
Instead of modifying the URL format, a new ad-hoc parser is introduced
to convert the m2 URL into maven coordinates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2778: Restore original format of m2:/ URLs modified by aa256463dcefb3b95bec6b7ac74e04a960015bc9
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2778:
URL: https://github.com/apache/netbeans/pull/2778#issuecomment-784967142
+1 to this (and/or -1 to #2777 )
> but then I decided to prefer using the same format for binaries-files as well as m2:/.
I don't understand this. `m2:/` had a format? eg. as specified at https://github.com/apache/netbeans/blob/master/java/maven.embedder/src/org/netbeans/modules/maven/embedder/impl/MavenProtocolHandler.java and (later) by https://github.com/apache/netbeans/blob/master/platform/core.startup/src/org/netbeans/core/startup/MavenRepoURLHandler.java
> a new ad-hoc parser is introduced to convert the m2 URL into maven coordinates.
Well, I guess would be nice if it wasn't parsed in slightly different ways in multiple places, but I'm not sure there's a way around that?! Then again, shame we're not using an external format like Package URL too ... :shrug:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2778: Restore original format of m2:/ URLs modified by aa256463dcefb3b95bec6b7ac74e04a960015bc9
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2778:
URL: https://github.com/apache/netbeans/pull/2778#issuecomment-784483948
@JaroslavTulach could you please have a look at this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2778: Restore original format of m2:/ URLs modified by aa256463dcefb3b95bec6b7ac74e04a960015bc9
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2778:
URL: https://github.com/apache/netbeans/pull/2778#issuecomment-785412226
- Travis is happy
- github actions mostly (the PHP cluster test runs for > 1 hour), as nothing in the PHP area depends on external urls, I consider this good enough
- the parser was modified, to also require the extension
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #2778: Restore original format of m2:/ URLs modified by aa256463dcefb3b95bec6b7ac74e04a960015bc9
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on a change in pull request #2778:
URL: https://github.com/apache/netbeans/pull/2778#discussion_r581858489
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/DownloadBinaries.java
##########
@@ -478,6 +472,47 @@ public static MavenCoordinate fromGradleFormat(String gradleFormat) {
}
return new MavenCoordinate(group, artifact, version, extension, classifier);
}
+
+ /**
+ * The maven coordinate is supplied in the form:
+ *
+ * <p>{@code m2:/group:name:version:extension:classifier}</p>
+ *
+ * <p>For the DownloadBinaries task the parts group, name and version
Review comment:
Not sure what the "canonical" format is, but should extension be required, as in https://github.com/apache/netbeans/blob/master/java/maven.embedder/src/org/netbeans/modules/maven/embedder/impl/MavenProtocolHandler.java ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2778: Restore original format of m2:/ URLs modified by aa256463dcefb3b95bec6b7ac74e04a960015bc9
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2778:
URL: https://github.com/apache/netbeans/pull/2778
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists