You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "lixingjia77 (via GitHub)" <gi...@apache.org> on 2024/10/15 01:22:18 UTC
[PR] bugfix: resolve issue in Raft model a follower's crash may lead to the continued use of expired tokens [incubator-seata]
lixingjia77 opened a new pull request, #6925:
URL: https://github.com/apache/incubator-seata/pull/6925
… client to continued use of expired tokens
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
解决raft模式下，follower崩溃可能导致client继续使用过期令牌的问题
resolve issue in Raft model where follower crashes could lead client to continued use of expired tokens
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #6917
In RaftRegistryServiceImpl#refreshToken, the tokenTimeStamp is updated before the request to obtain the token is sent, and there is no check for whether the HTTP status is normal.
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: resolve issue in Raft model a follower's crash may lead to the continued use of expired tokens [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #6925:
URL: https://github.com/apache/incubator-seata/pull/6925#issuecomment-2412949568
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6925?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 51.75%. Comparing base [(`980ba23`)](https://app.codecov.io/gh/apache/incubator-seata/commit/980ba23b82c372c3f201e2d7beb3d5be62e081f1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6696fc5`)](https://app.codecov.io/gh/apache/incubator-seata/commit/6696fc52f5541591d053f5514822181caffe193e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6925?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6925 +/- ##
============================================
+ Coverage 51.72% 51.75% +0.03%
Complexity 6456 6456
============================================
Files 1122 1122
Lines 39857 39857
Branches 4668 4670 +2
============================================
+ Hits 20616 20628 +12
+ Misses 17280 17269 -11
+ Partials 1961 1960 -1
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/6925?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...scovery/registry/raft/RaftRegistryServiceImpl.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6925?src=pr&el=tree&filepath=discovery%2Fseata-discovery-raft%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fdiscovery%2Fregistry%2Fraft%2FRaftRegistryServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGlzY292ZXJ5L3NlYXRhLWRpc2NvdmVyeS1yYWZ0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9kaXNjb3ZlcnkvcmVnaXN0cnkvcmFmdC9SYWZ0UmVnaXN0cnlTZXJ2aWNlSW1wbC5qYXZh) | `17.69% <100.00%> (ø)` | |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6925/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: resolve issue in Raft model a follower's crash may lead to the continued use of expired tokens [incubator-seata]
Posted by "lixingjia77 (via GitHub)" <gi...@apache.org>.
lixingjia77 commented on code in PR #6925:
URL: https://github.com/apache/incubator-seata/pull/6925#discussion_r1800504545
##########
changes/en-us/2.x.md:
##########
@@ -12,6 +12,7 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6899](https://github.com/apache/incubator-seata/pull/6899)] fix file.conf read failed after package
- [[#6890](https://github.com/apache/incubator-seata/pull/6890)] fix designerJson to standardJson: subStateMachine compensateState cannot be recognized
- [[#6907](https://github.com/apache/incubator-seata/pull/6907)] fix the issue of Codecov not generating reports
+- [[#6925](https://github.com/apache/incubator-seata/pull/6925)] fix the issue in Raft model a follower's crash may lead to the continued use of expired tokens
Review Comment:
Thanks for your reminder, the developer info has been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: resolve issue in Raft model a follower's crash may lead to the continued use of expired tokens [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6925:
URL: https://github.com/apache/incubator-seata/pull/6925#discussion_r1800483058
##########
changes/en-us/2.x.md:
##########
@@ -12,6 +12,7 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6899](https://github.com/apache/incubator-seata/pull/6899)] fix file.conf read failed after package
- [[#6890](https://github.com/apache/incubator-seata/pull/6890)] fix designerJson to standardJson: subStateMachine compensateState cannot be recognized
- [[#6907](https://github.com/apache/incubator-seata/pull/6907)] fix the issue of Codecov not generating reports
+- [[#6925](https://github.com/apache/incubator-seata/pull/6925)] fix the issue in Raft model a follower's crash may lead to the continued use of expired tokens
Review Comment:
最下方的开发者信息也需要登记
The developer information at the bottom also requires registration.
##########
changes/zh-cn/2.x.md:
##########
@@ -12,6 +12,7 @@
- [[#6899](https://github.com/apache/incubator-seata/pull/6899)] 修复file.conf打包后的读取
- [[#6890](https://github.com/apache/incubator-seata/pull/6890)] 修复saga设计json转标准json过程中: 子状态机补偿节点无法被识别
- [[#6907](https://github.com/apache/incubator-seata/pull/6907)] 修复Codecov未生成报告的问题
+- [[#6925](https://github.com/apache/incubator-seata/pull/6925)] 修复Raft模式下，Follower崩溃可能导致Client继续使用过期令牌的问题
Review Comment:
最下方的开发者信息也需要登记
The developer information at the bottom also requires registration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: resolve issue in Raft model a follower's crash may lead to the continued use of expired tokens [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6925:
URL: https://github.com/apache/incubator-seata/pull/6925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org