You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Steffen <in...@apachelounge.com> on 2012/03/01 12:15:23 UTC

Still #ifdef WIN64 in APR

In APR 1.4.6 there is still a typo in the statements, causes crashes HTTPD in eg. setting on logging in mod_rewrite.

In shm.c and apr.hw

#ifdef WIN64

Sould be:

#ifdef _WIN64



Steffen

Re: Still #ifdef WIN64 in APR

Posted by Jeff Trawick <tr...@gmail.com>.
On Thu, Mar 1, 2012 at 8:23 AM, Mladen Turk <mt...@apache.org> wrote:
> On 03/01/2012 01:19 PM, Jeff Trawick wrote:
>>
>>
>> Regardless of the APR_SIZEOF_VOIDP issue, it should be _WIN64 in the
>> .c/.h code.  I'll commit that.  I guess the attribution to use is the
>> e-mail address in bug 49155.
>>
>
> _WIN64 is defined by cl.exe (same as WIN32/_WIN32)
>
> WIN64 should be defined by make files, but agreed that's just
> needless duplication. In case mingw64 doesn't defines _WIN64, this should
> be added to configure.

apparently it does (see the recap in the second post at
http://groups.google.com/group/mpir-devel/browse_thread/thread/e8c4aa0e4f4daafd?pli=1)

I don't have 64-bit MINGW set up locally to confirm, but that's good
enough for me.

Re: Still #ifdef WIN64 in APR

Posted by Mladen Turk <mt...@apache.org>.
On 03/01/2012 01:19 PM, Jeff Trawick wrote:
>
> Regardless of the APR_SIZEOF_VOIDP issue, it should be _WIN64 in the
> .c/.h code.  I'll commit that.  I guess the attribution to use is the
> e-mail address in bug 49155.
>

_WIN64 is defined by cl.exe (same as WIN32/_WIN32)

WIN64 should be defined by make files, but agreed that's just
needless duplication. In case mingw64 doesn't defines _WIN64, this should
be added to configure.


Regards
-- 
^TM

Re: Still #ifdef WIN64 in APR

Posted by Jeff Trawick <tr...@gmail.com>.
On Thu, Mar 1, 2012 at 7:04 AM, Eric Covener <co...@gmail.com> wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=49155 says:
>
> APR_SIZEOF_VOIDP isn't defined as 8 because of the "#ifdef WIN64" statement
> preceding "#define APR_SIZEOF_VOIDP 8" in the apr.hw file. It is supposed be
> "#ifdef _WIN64". There is another "#ifdef WIN64" in apr.hw which should also be
> changed to "#ifdef _WIN64".

See also http://stackoverflow.com/a/1648031

So the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=40758 was bad?

We also have this reference to "WIN64":

./libapr.rc:#if defined(WINNT) || defined(WIN64)

If the post I found is correct, any such checks will work only because
the project has defined the symbol.  However, I don't see WIN64
getting defined so I don't know why it is checked.  (And we seem to
define WINNT for 64-bit builds.)

Regardless of the APR_SIZEOF_VOIDP issue, it should be _WIN64 in the
.c/.h code.  I'll commit that.  I guess the attribution to use is the
e-mail address in bug 49155.


> ---------- Forwarded message ----------
> From: Steffen <in...@apachelounge.com>
> Date: Thu, Mar 1, 2012 at 6:15 AM
> Subject: Still #ifdef WIN64 in APR
> To: dev@httpd.apache.org
>
>
> In APR 1.4.6 there is still a typo in the statements, causes crashes
> HTTPD in eg. setting on logging in mod_rewrite.
>
> In shm.c and apr.hw
>
> #ifdef WIN64
>
> Sould be:
>
> #ifdef _WIN64
>
>
>
> Steffen
>
>
> --
> Eric Covener
> covener@gmail.com



-- 
Born in Roswell... married an alien...

Fwd: Still #ifdef WIN64 in APR

Posted by Eric Covener <co...@gmail.com>.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49155 says:

APR_SIZEOF_VOIDP isn't defined as 8 because of the "#ifdef WIN64" statement
preceding "#define APR_SIZEOF_VOIDP 8" in the apr.hw file. It is supposed be
"#ifdef _WIN64". There is another "#ifdef WIN64" in apr.hw which should also be
changed to "#ifdef _WIN64".


---------- Forwarded message ----------
From: Steffen <in...@apachelounge.com>
Date: Thu, Mar 1, 2012 at 6:15 AM
Subject: Still #ifdef WIN64 in APR
To: dev@httpd.apache.org


In APR 1.4.6 there is still a typo in the statements, causes crashes
HTTPD in eg. setting on logging in mod_rewrite.

In shm.c and apr.hw

#ifdef WIN64

Sould be:

#ifdef _WIN64



Steffen


-- 
Eric Covener
covener@gmail.com

Re: Still #ifdef WIN64 in APR

Posted by Steffen <in...@apachelounge.com>.
Anindya supplies already some time a build with the change,
as far as I know, no issues reported.


-----Original Message----- 
From: Jeff Trawick
Sent: Thursday, March 01, 2012 1:30 PM Newsgroups: gmane.comp.apache.devel
To: dev@httpd.apache.org ; APR Developer List
Subject: Re: Still #ifdef WIN64 in APR

On Thu, Mar 1, 2012 at 6:15 AM, Steffen <in...@apachelounge.com> wrote:
> In APR 1.4.6 there is still a typo in the statements, causes crashes HTTPD
> in eg. setting on logging in mod_rewrite.
>
> In shm.c and apr.hw
>
> #ifdef WIN64
>
> Sould be:
>
> #ifdef _WIN64
>
>
>
> Steffen

Does this work for you?

http://svn.apache.org/viewvc?view=revision&revision=1295535

(I'll move the fix back to 1.5 and 1.4 branches and retarget the bug to 
apr.)



-- 
Born in Roswell... married an alien...

Re: Still #ifdef WIN64 in APR

Posted by Eric Covener <co...@gmail.com>.
> Does this work for you?
>
> http://svn.apache.org/viewvc?view=revision&revision=1295535
>
> (I'll move the fix back to 1.5 and 1.4 branches and retarget the bug to apr.)

Looks right here given the report and stackoverflow post.

Re: Still #ifdef WIN64 in APR

Posted by Eric Covener <co...@gmail.com>.
> Does this work for you?
>
> http://svn.apache.org/viewvc?view=revision&revision=1295535
>
> (I'll move the fix back to 1.5 and 1.4 branches and retarget the bug to apr.)

Looks right here given the report and stackoverflow post.

Re: Still #ifdef WIN64 in APR

Posted by Jeff Trawick <tr...@gmail.com>.
On Thu, Mar 1, 2012 at 6:15 AM, Steffen <in...@apachelounge.com> wrote:
> In APR 1.4.6 there is still a typo in the statements, causes crashes HTTPD
> in eg. setting on logging in mod_rewrite.
>
> In shm.c and apr.hw
>
> #ifdef WIN64
>
> Sould be:
>
> #ifdef _WIN64
>
>
>
> Steffen

Does this work for you?

http://svn.apache.org/viewvc?view=revision&revision=1295535

(I'll move the fix back to 1.5 and 1.4 branches and retarget the bug to apr.)



-- 
Born in Roswell... married an alien...

Re: Still #ifdef WIN64 in APR

Posted by Jeff Trawick <tr...@gmail.com>.
On Thu, Mar 1, 2012 at 6:15 AM, Steffen <in...@apachelounge.com> wrote:
> In APR 1.4.6 there is still a typo in the statements, causes crashes HTTPD
> in eg. setting on logging in mod_rewrite.
>
> In shm.c and apr.hw
>
> #ifdef WIN64
>
> Sould be:
>
> #ifdef _WIN64
>
>
>
> Steffen

Does this work for you?

http://svn.apache.org/viewvc?view=revision&revision=1295535

(I'll move the fix back to 1.5 and 1.4 branches and retarget the bug to apr.)



-- 
Born in Roswell... married an alien...