You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/11/14 18:21:32 UTC

[GitHub] [spark] rxin commented on a change in pull request #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset

rxin commented on a change in pull request #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset
URL: https://github.com/apache/spark/pull/26509#discussion_r346471807
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala
 ##########
 @@ -46,11 +47,13 @@ import org.apache.spark.sql.types.{NumericType, StructType}
  * @since 2.0.0
  */
 @Stable
-class RelationalGroupedDataset protected[sql](
-    private[sql] val df: DataFrame,
+class RelationalGroupedDataset[T] protected[sql](
 
 Review comment:
   This would break source compatibility. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org