[GitHub] ctubbsii commented on a change in pull request #841: Refactored SiteConfiguration

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #841: Refactored SiteConfiguration
URL: https://github.com/apache/accumulo/pull/841#discussion_r243018954
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/clientImpl/ClientConfConverter.java
 ##########
 @@ -166,19 +166,14 @@ public String get(Property property) {
         if (property.isSensitive()) {
           org.apache.hadoop.conf.Configuration hadoopConf = getHadoopConfiguration();
           if (hadoopConf != null) {
-            try {
-              char[] value = CredentialProviderFactoryShim
-                  .getValueFromCredentialProvider(hadoopConf, key);
-              if (value != null) {
-                log.trace("Loaded sensitive value for {} from CredentialProvider", key);
-                return new String(value);
-              } else {
-                log.trace("Tried to load sensitive value for {} from CredentialProvider, "
-                    + "but none was found", key);
-              }
-            } catch (IOException e) {
-              log.warn("Failed to extract sensitive property ({}) from Hadoop CredentialProvider,"
-                  + " falling back to base AccumuloConfiguration", key, e);
+            char[] value = CredentialProviderFactoryShim.getValueFromCredentialProvider(hadoopConf,
 
 Review comment:
   I don't think this credential provider stuff is very robust, as is... I'd be okay with ripping it out (or deprecating, so we can rip it out later, in favor of a better implementation for configuration property source provider).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services