You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/09/19 18:46:19 UTC

[GitHub] [cordova-ios] ArcTanSusan opened a new pull request #671: (#659) Remove CONFIGURATION_BUILD_DIR default string

ArcTanSusan opened a new pull request #671: (#659) Remove CONFIGURATION_BUILD_DIR default string
URL: https://github.com/apache/cordova-ios/pull/671
 
 
   #487 # Platforms affected
   * all
   
   ### Motivation and Context
   https://github.com/apache/cordova-ios/issues/659
   
   ### Description
   Remove CONFIGURATION_BUILD_DIR default string. Use the user custom defined CONFIGURATION_BUILD_DIR as the default and if undefined, then the value is an empty string.
   
   ### Testing
   Modified unittests to no longer have a default hard-coded `CONFIGURATION_BUILD_DIR` value.
   
   
   ### Checklist
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org