[GitHub] orc pull request #41: ORC-58: Move code for reading rows from Reader to RowR...

[swalkaus <gi...@git.apache.org>]

Github user swalkaus commented on a diff in the pull request:

    https://github.com/apache/orc/pull/41#discussion_r70967406
  
    --- Diff: tools/src/FileContents.cc ---
    @@ -27,8 +27,10 @@
     #include <string>
     
     void printContents(const char* filename, const orc::ReaderOptions opts) {
    -  std::unique_ptr<orc::Reader> reader;
    -  reader = orc::createReader(orc::readLocalFile(std::string(filename)), opts);
    +  std::unique_ptr<orc::Reader> fileReader;
    --- End diff --
    
    Pendantic: use reader and rowReader consistently (notice the camelCase).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---