[GitHub] [cloudstack-documentation] rohityadavcloud commented on a diff in pull request #320: docs: Update instructions for adding DEB repository

["rohityadavcloud (via GitHub)" <gi...@apache.org>]

rohityadavcloud commented on code in PR #320:
URL: https://github.com/apache/cloudstack-documentation/pull/320#discussion_r1211427547


##########
source/installguide/management-server/_pkg_repo.rst:
##########
@@ -99,19 +99,19 @@ repository to the file (replace "trusty" with "xenial" or "bionic" if it is the
 
 .. parsed-literal::
 
-   deb http://download.cloudstack.org/ubuntu focal |version|
+   deb https://download.cloudstack.org/ubuntu focal |version|
 
 We now have to add the public key to the trusted keys.
 
 .. parsed-literal::
 
-   wget -O - http://download.cloudstack.org/release.asc |sudo apt-key add -
+   wget -O - https://download.cloudstack.org/release.asc |sudo tee /etc/apt/trusted.gpg.d/cloudstack.asc

Review Comment:
   Should this be, something like:
   ```
   mkdir -p /etc/apt/keyrings
   wget -O- https://download.cloudstack.org/release.asc | gpg --dearmor | sudo tee /etc/apt/keyrings/cloudstack.gpg > /dev/null
   ```
   And for use for the repo, the usage is like or something similar:
   ```
   echo deb [signed-by=/etc/apt/keyrings/cloudstack.gpg] https://download.cloudstack.org/<path to repo here> / > /etc/apt/sources.list.d/cloudstack.list
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org