You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/03/23 02:04:28 UTC
[kudu-CR] consensus: Enforce terminal health status for FAILED UNRECOVERABLE
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9779
to review the following change.
Change subject: consensus: Enforce terminal health status for FAILED_UNRECOVERABLE
......................................................................
consensus: Enforce terminal health status for FAILED_UNRECOVERABLE
This patch adds a DCHECK to the consensus queue that we never transition
from FAILED_UNRECOVERABLE to some other health state for a given peer.
Added some comments documenting the state transition rules to the
protobuf definition as well.
Change-Id: Ide4cb453f1cd1b955a73e9ddd58ca5ecd90b2e9c
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/metadata.proto
2 files changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/9779/1
--
To view, visit http://gerrit.cloudera.org:8080/9779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide4cb453f1cd1b955a73e9ddd58ca5ecd90b2e9c
Gerrit-Change-Number: 9779
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] consensus: Enforce terminal health status for FAILED UNRECOVERABLE
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9779 )
Change subject: consensus: Enforce terminal health status for FAILED_UNRECOVERABLE
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9779/2/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:
http://gerrit.cloudera.org:8080/#/c/9779/2/src/kudu/consensus/consensus_queue.cc@546
PS2, Line 546: ValidatePeerHealthStateTransition
> If it's just a single place where this function is used, maybe just move it
Sure. I was originally expecting a somewhat meatier function.
--
To view, visit http://gerrit.cloudera.org:8080/9779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide4cb453f1cd1b955a73e9ddd58ca5ecd90b2e9c
Gerrit-Change-Number: 9779
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 23 Mar 2018 04:31:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] consensus: Enforce terminal health status for FAILED UNRECOVERABLE
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9779 )
Change subject: consensus: Enforce terminal health status for FAILED_UNRECOVERABLE
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9779/2/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:
http://gerrit.cloudera.org:8080/#/c/9779/2/src/kudu/consensus/consensus_queue.cc@546
PS2, Line 546: ValidatePeerHealthStateTransition
If it's just a single place where this function is used, maybe just move its body in here and get rid of the function at all?
--
To view, visit http://gerrit.cloudera.org:8080/9779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide4cb453f1cd1b955a73e9ddd58ca5ecd90b2e9c
Gerrit-Change-Number: 9779
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 23 Mar 2018 03:28:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] consensus: Enforce terminal health status for FAILED UNRECOVERABLE
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9779 )
Change subject: consensus: Enforce terminal health status for FAILED_UNRECOVERABLE
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide4cb453f1cd1b955a73e9ddd58ca5ecd90b2e9c
Gerrit-Change-Number: 9779
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 23 Mar 2018 05:51:41 +0000
Gerrit-HasComments: No
[kudu-CR] consensus: Enforce terminal health status for FAILED UNRECOVERABLE
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9779 )
Change subject: consensus: Enforce terminal health status for FAILED_UNRECOVERABLE
......................................................................
consensus: Enforce terminal health status for FAILED_UNRECOVERABLE
This patch adds a DCHECK to the consensus queue that we never transition
from FAILED_UNRECOVERABLE to some other health state for a given peer.
Added some comments documenting the state transition rules to the
protobuf definition as well.
Change-Id: Ide4cb453f1cd1b955a73e9ddd58ca5ecd90b2e9c
Reviewed-on: http://gerrit.cloudera.org:8080/9779
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/metadata.proto
2 files changed, 16 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide4cb453f1cd1b955a73e9ddd58ca5ecd90b2e9c
Gerrit-Change-Number: 9779
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] consensus: Enforce terminal health status for FAILED UNRECOVERABLE
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9779
to look at the new patch set (#3).
Change subject: consensus: Enforce terminal health status for FAILED_UNRECOVERABLE
......................................................................
consensus: Enforce terminal health status for FAILED_UNRECOVERABLE
This patch adds a DCHECK to the consensus queue that we never transition
from FAILED_UNRECOVERABLE to some other health state for a given peer.
Added some comments documenting the state transition rules to the
protobuf definition as well.
Change-Id: Ide4cb453f1cd1b955a73e9ddd58ca5ecd90b2e9c
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/metadata.proto
2 files changed, 16 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/9779/3
--
To view, visit http://gerrit.cloudera.org:8080/9779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ide4cb453f1cd1b955a73e9ddd58ca5ecd90b2e9c
Gerrit-Change-Number: 9779
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] consensus: Enforce terminal health status for FAILED UNRECOVERABLE
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9779
to look at the new patch set (#2).
Change subject: consensus: Enforce terminal health status for FAILED_UNRECOVERABLE
......................................................................
consensus: Enforce terminal health status for FAILED_UNRECOVERABLE
This patch adds a DCHECK to the consensus queue that we never transition
from FAILED_UNRECOVERABLE to some other health state for a given peer.
Added some comments documenting the state transition rules to the
protobuf definition as well.
Change-Id: Ide4cb453f1cd1b955a73e9ddd58ca5ecd90b2e9c
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/metadata.proto
2 files changed, 22 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/9779/2
--
To view, visit http://gerrit.cloudera.org:8080/9779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ide4cb453f1cd1b955a73e9ddd58ca5ecd90b2e9c
Gerrit-Change-Number: 9779
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins