[2/2] hbase git commit: HBASE-20438 Add an HBase antipattern check for reintroducing commons-logging

[bu...@apache.org]

HBASE-20438 Add an HBase antipattern check for reintroducing commons-logging

Signed-off-by: Sean Busbey <bu...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/0207ed03
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/0207ed03
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/0207ed03

Branch: refs/heads/branch-2.0
Commit: 0207ed03f3bdf4a800c575f9414d1abe7062a49a
Parents: d8985e0
Author: Nihal Jain <ni...@gmail.com>
Authored: Wed Apr 18 23:03:07 2018 +0530
Committer: Sean Busbey <bu...@apache.org>
Committed: Fri Apr 20 11:59:03 2018 -0500

----------------------------------------------------------------------
 dev-support/hbase-personality.sh | 6 ++++++
 1 file changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/0207ed03/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index e047a5a..c616be2 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -642,6 +642,12 @@ function hbaseanti_patchfile
     ((result=result+1))
   fi
 
+  warnings=$(${GREP} -cE 'org.apache.commons.logging.Log(Factory|;)' "${patchfile}")
+  if [[ ${warnings} -gt 0 ]]; then
+    add_vote_table -1 hbaseanti "" "The patch appears to use commons-logging instead of slf4j."
+    ((result=result+1))
+  fi
+
   if [[ ${result} -gt 0 ]]; then
     return 1
   fi