You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2016/01/15 12:08:01 UTC

[Bug 58870] New: TableEditor minimal size is too short

https://bz.apache.org/bugzilla/show_bug.cgi?id=58870

            Bug ID: 58870
           Summary: TableEditor minimal size is too short
           Product: JMeter
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: vherilier@gmail.com

As a JMeter windows is reduced in height or has a too small height and if
there's a TableEditor widget in the shown element, the widget could be reduced
in heigth to the height of the header row only.
It could be useful to limit its minimal height

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58870] TableEditor: minimum size is too small

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58870

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Thu Feb 18 12:51:28 2016
New Revision: 1731061

URL: http://svn.apache.org/viewvc?rev=1731061&view=rev
Log:
Bug 58870 - TableEditor: minimum size is too small
#resolve #128
Bugzilla Id: 58870

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TableEditor.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58870] TableEditor: minimum size is too small

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58870

--- Comment #5 from Vincent HERILIER <vh...@gmail.com> ---
Thanks a lot

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58870] TableEditor: minimun size is too short

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58870

Vincent HERILIER <vh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|TableEditor minimal size is |TableEditor: minimun size
                   |too short                   |is too short

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58870] TableEditor: minimum size is too small

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58870

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
            Summary|TableEditor: minimun size   |TableEditor: minimum size
                   |is too short                |is too small

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58870] TableEditor minimal size is too short

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58870

--- Comment #1 from Vincent HERILIER <vh...@gmail.com> ---
Setting the minimum size in the makePanel method insures not reducing too much
the widget and allows to see if there's at least a row inside

By my side I'm using "scroller.setMinimumSize(new Dimension(100, 70));" to set
it

...
private JComponent makePanel()
    {
        JPanel p = new JPanel(new BorderLayout());
        JScrollPane scroller = new JScrollPane(table);
        scroller.setMinimumSize(new Dimension(100, 70));
        scroller.setPreferredSize(scroller.getMinimumSize());
        p.add(scroller,BorderLayout.CENTER);
        JPanel south = new JPanel();
...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58870] TableEditor: minimun size is too short

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58870

--- Comment #2 from Vincent HERILIER <vh...@gmail.com> ---
Created attachment 33495
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33495&action=edit
limit the minimun size of TableEditor UI widget to show header row and at least
2 data rows

patch that fixes the minimum size to the TableEditor UI widget when the windows
is size reduced, the widget will no more be reduced until its header height. At
least 2 rows will be shown

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58870] TableEditor: minimun size is too short

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58870

--- Comment #3 from Vincent HERILIER <vh...@gmail.com> ---
made a PR#128: https://github.com/apache/jmeter/pull/128

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58870] TableEditor: minimun size is too short

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58870

Vincent HERILIER <vh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33495|limit the minimun size of   |limits the minimun size of
        description|TableEditor UI widget to    |TableEditor UI widget to
                   |show header row and at      |show header row and at
                   |least 2 data rows           |least 2 data rows

-- 
You are receiving this mail because:
You are the assignee for the bug.