You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/03/12 20:38:49 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #40365: [MINOR][SQL] Fix incorrect comment in LimitPushDownThroughWindow

dongjoon-hyun commented on code in PR #40365:
URL: https://github.com/apache/spark/pull/40365#discussion_r1133318969


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushDownThroughWindow.scala:
##########
@@ -30,7 +30,7 @@ import org.apache.spark.sql.catalyst.trees.TreePattern.{LIMIT, WINDOW}
  * }}}
  */
 object LimitPushDownThroughWindow extends Rule[LogicalPlan] {
-  // The window frame of RankLike and RowNumberLike can only be UNBOUNDED PRECEDING to CURRENT ROW.
+  // The window frame of Rank, DenseRank and RowNumber can only be UNBOUNDED PRECEDING to CURRENT ROW.

Review Comment:
   This seems to exceed 100 line and this PR didn't pass the CI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org