You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Stephane Nicoll (JIRA)" <ji...@codehaus.org> on 2007/05/01 17:45:26 UTC

[jira] Closed: (MPWAR-65) Problems with maven.war.property.expansion

     [ http://jira.codehaus.org/browse/MPWAR-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephane Nicoll closed MPWAR-65.
--------------------------------

    Resolution: Fixed

Added maven.war.expansion.excludes property to exclude files during a property expansion copy (Fixes corruption of binary files). Applied property expansion to web.xml handling for consistency. Introduced the maven.war.src.filtering property to control whether filtering is enabled or not when copying webapp resources.

> Problems with maven.war.property.expansion
> ------------------------------------------
>
>                 Key: MPWAR-65
>                 URL: http://jira.codehaus.org/browse/MPWAR-65
>             Project: maven-war-plugin
>          Issue Type: Bug
>    Affects Versions: 1.6.2
>            Reporter: Caleb Lyness
>            Assignee: Stephane Nicoll
>             Fix For: 1.6.3
>
>
> When you use the maven.war.property.expansion=true, all resources in your webapps folder are all modified. This is fine, but some binary files (for example image) are broken in the process. I would propose that 2 variable are added, apon which the filter set can be further specified.
> maven.war.property.expansion.includes
> maven.war.property.expansion.excludes
> In this way specific files may have the expansion applied to them or avoid any meddling.
> Also, note that the special treatment of web.xml conflicts with the maven.war.property.expansion.
> The web.xml is copied and filtered during the main copy step (including expansion). Then later
> it is copied again, without expansion, overwritting the original file. This can be worked around by 
> setting maven.war.webxml=nonexistentfile or by having maven.war.webxml.overwrite=false
> The expansion code should be added to the second stage as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira