You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/12/03 20:20:55 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #71: Rename sbt akka modules
mdedetrich opened a new pull request, #71:
URL: https://github.com/apache/incubator-pekko/pull/71
Currently in draft, tbd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] seglo commented on a diff in pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
seglo commented on code in PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#discussion_r1061680803
##########
LICENSE:
##########
@@ -207,6 +207,6 @@ Licenses for dependency projects can be found here:
---------------
-akka-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
+pekko-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
Review Comment:
I think it makes sense to use the artifact id here, but I noticed in `CONTRIBUTING` everything is referred to using the path/project name. I think in docs it would be better to reference by artifact name.
##########
LICENSE:
##########
@@ -207,6 +207,6 @@ Licenses for dependency projects can be found here:
---------------
-akka-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
+pekko-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
moved into the source package `akka.protobuf` so as to avoid version conflicts.
Review Comment:
```suggestion
moved into the source package `org.apache.pekko.protobuf` so as to avoid version conflicts.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#issuecomment-1337335245
My preference is to have the dir name match the module/jar name. One of my key reasons for this is that in the docs, you don't have to worry about whether we need to replace with akka-actor with actor or pekko-actor - because sometimes in the existing docs, akka-actor can refer to a file location and sometimes to the module/jar name. I just think we'll end up with fewer issues in the docs if we just use the 'pekko-' dir names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#issuecomment-1370670660
So the PR is ready to review, I haven't had time to make an alternate version that doesn't drop the prefix but I since this is kind of a blocker for pekko we can always put the prefix back if there is strong pushback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
He-Pin commented on code in PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#discussion_r1045506893
##########
build.sbt:
##########
@@ -102,10 +102,10 @@ lazy val root = Project(id = "pekko", base = file("."))
.settings(PekkoBuild.welcomeSettings)
.enablePlugins(CopyrightHeaderForBuild)
-lazy val actor = akkaModule("akka-actor")
+lazy val actor = pekkoModule("actor")
Review Comment:
take it easy, I'm busy at 12.12 shopping festival too:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] seglo commented on pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
seglo commented on PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#issuecomment-1366338807
I don't have a strong opinion. I see the logic in either approach, but with all of these house cleaning tasks I would lean towards making as few changes as possible to expedite a 1.0.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#issuecomment-1370803175
So I will wait for one more approval since its such a major change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#issuecomment-1371238879
> I assume this statement is still true?
Yes, aside from one exception (noted below). Here is a diff
Before
```
[info] akka-cluster-tools / name
[info] akka-cluster-tools
[info] akka-protobuf / name
[info] akka-protobuf
[info] akka-cluster-metrics / name
[info] akka-cluster-metrics
[info] docs / name
[info] docs
[info] akka-stream-testkit / name
[info] akka-stream-testkit
[info] akka-osgi / name
[info] akka-osgi
[info] akka-stream / name
[info] akka-stream
[info] akka-stream-tests-tck / name
[info] akka-stream-tests-tck
[info] akka-persistence-shared / name
[info] akka-persistence-shared
[info] akka-persistence / name
[info] akka-persistence
[info] akka-actor-typed / name
[info] akka-actor-typed
[info] akka-actor-tests / name
[info] akka-actor-tests
[info] akka-distributed-data / name
[info] akka-distributed-data
[info] akka-persistence-typed / name
[info] akka-persistence-typed
[info] akka-bench-jmh / name
[info] akka-bench-jmh
[info] akka-cluster-sharding-typed / name
[info] akka-cluster-sharding-typed
[info] akka-persistence-typed-tests / name
[info] akka-persistence-typed-tests
[info] akka-discovery / name
[info] akka-discovery
[info] akka-protobuf-v3 / name
[info] akka-protobuf-v3
[info] akka-coordination / name
[info] akka-coordination
[info] akka-actor-testkit-typed / name
[info] akka-actor-testkit-typed
[info] akka-stream-typed / name
[info] akka-stream-typed
[info] akka-remote / name
[info] akka-remote
[info] akka-remote-tests / name
[info] akka-remote-tests
[info] akka-stream-tests / name
[info] akka-stream-tests
[info] akka-pki / name
[info] akka-pki
[info] akka-actor-typed-tests / name
[info] akka-actor-typed-tests
[info] akka-testkit / name
[info] akka-testkit
[info] akka-persistence-query / name
[info] akka-persistence-query
[info] akka-cluster-typed / name
[info] akka-cluster-typed
[info] akka-persistence-tck / name
[info] akka-persistence-tck
[info] akka-multi-node-testkit / name
[info] akka-multi-node-testkit
[info] akka-serialization-jackson / name
[info] akka-serialization-jackson
[info] akka-persistence-testkit / name
[info] akka-persistence-testkit
[info] akka-actor / name
[info] akka-actor
[info] akka-cluster / name
[info] akka-cluster
[info] akka-bill-of-materials / name
[info] akka-bom
[info] akka-slf4j / name
[info] akka-slf4j
[info] akka-cluster-sharding / name
[info] akka-cluster-sharding
[info] name
[info] pekko
```
After (this PR)
```
[IJ]pekko > name
[info] pki / name
[info] pekko-pki
[info] actor-testkit-typed / name
[info] pekko-actor-testkit-typed
[info] coordination / name
[info] pekko-coordination
[info] cluster-sharding-typed / name
[info] pekko-cluster-sharding-typed
[info] actor-typed / name
[info] pekko-actor-typed
[info] docs / name
[info] pekko-docs
[info] actor-typed-tests / name
[info] pekko-actor-typed-tests
[info] testkit / name
[info] pekko-testkit
[info] stream / name
[info] pekko-stream
[info] multi-node-testkit / name
[info] pekko-multi-node-testkit
[info] persistence-query / name
[info] pekko-persistence-query
[info] osgi / name
[info] pekko-osgi
[info] persistence-typed-tests / name
[info] pekko-persistence-typed-tests
[info] persistence-testkit / name
[info] pekko-persistence-testkit
[info] persistence / name
[info] pekko-persistence
[info] cluster-tools / name
[info] pekko-cluster-tools
[info] remote-tests / name
[info] pekko-remote-tests
[info] protobuf-v3 / name
[info] pekko-protobuf-v3
[info] stream-tests-tck / name
[info] pekko-stream-tests-tck
[info] protobuf / name
[info] pekko-protobuf
[info] actor / name
[info] pekko-actor
[info] discovery / name
[info] pekko-discovery
[info] bench-jmh / name
[info] pekko-bench-jmh
[info] cluster-metrics / name
[info] pekko-cluster-metrics
[info] bill-of-materials / name
[info] pekko-bom
[info] stream-tests / name
[info] pekko-stream-tests
[info] stream-testkit / name
[info] pekko-stream-testkit
[info] remote / name
[info] pekko-remote
[info] distributed-data / name
[info] pekko-distributed-data
[info] cluster / name
[info] pekko-cluster
[info] actor-tests / name
[info] pekko-actor-tests
[info] slf4j / name
[info] pekko-slf4j
[info] cluster-typed / name
[info] pekko-cluster-typed
[info] serialization-jackson / name
[info] pekko-serialization-jackson
[info] persistence-tck / name
[info] pekko-persistence-tck
[info] stream-typed / name
[info] pekko-stream-typed
[info] persistence-shared / name
[info] pekko-persistence-shared
[info] persistence-typed / name
[info] pekko-persistence-typed
[info] cluster-sharding / name
[info] pekko-cluster-sharding
[info] name
[info] pekko-root
```
The exception being root, which rather than being `pekko` is `pekko-root` (was previously `akka`). This is done to make it consistent with an upcoming PR in incubator-pekko but it has no effect on the project because the root project is never deployed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] spangaer commented on pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
spangaer commented on PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#issuecomment-1355039851
(Catching Up)
GH doesn't really like these big diffs too 🤷
But I see no list thread was started on the subject so I'll continue here.
Anyhow, I tend to side with the folder names match project ID's match artifact ID's.
The one I'd dare doubt about is the sbt reference, which is used to send a command to a specific project, because I see some justification in saving on chars on things you potentially hand type, but it's not a strong feeling. I see the benefit of consistency too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#discussion_r1038950298
##########
LICENSE:
##########
@@ -207,6 +207,6 @@ Licenses for dependency projects can be found here:
---------------
-akka-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
+protobuf contains the sources of Google protobuf 2.5.0 runtime support,
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#issuecomment-1336963932
@pjfanning So clearly I am a bit on the fence on this one, on one end this PR is actually done with all of the tests passing and I fixed a regression which was made when `akka-docs` was renamed to `docs` but on the other hand its inconsistent with what was recently merged into pekko-http.
Do you still feel really strongly about the directory naming? There are other improvements with the changes I have done that came as a result so another alternative option is that I make a PR at https://github.com/apache/incubator-pekko-http to remove the pekko prefix in dir names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#discussion_r1061747573
##########
LICENSE:
##########
@@ -207,6 +207,6 @@ Licenses for dependency projects can be found here:
---------------
-akka-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
+pekko-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
moved into the source package `akka.protobuf` so as to avoid version conflicts.
Review Comment:
Nice pickup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#issuecomment-1372019059
So I did `publishLocal` on this PR and on the latest Apache2 Akka code to see the produced artifacts
Akka ASL 2.0 with org `com.typesafe.akka`
```
akka-actor-testkit-typed_2.13
akka-actor-typed_2.13
akka-actor_2.13
akka-bom_2.13
akka-cluster-metrics_2.13
akka-cluster-sharding-typed_2.13
akka-cluster-sharding_2.13
akka-cluster-tools_2.13
akka-cluster-typed_2.13
akka-cluster_2.13
akka-coordination_2.13
akka-discovery_2.13
akka-distributed-data_2.13
akka-multi-node-testkit_2.13
akka-osgi_2.13
akka-persistence-query_2.13
akka-persistence-tck_2.13
akka-persistence-testkit_2.13
akka-persistence-typed_2.13
akka-persistence_2.13
akka-pki_2.13
akka-protobuf-v3_2.13
akka-protobuf_2.13
akka-remote_2.13
akka-serialization-jackson_2.13
akka-slf4j_2.13
akka-stream-testkit_2.13
akka-stream-typed_2.13
akka-stream_2.13
akka-testkit_2.13
```
Pekko (this branch/PR) with org `org.apache.pekko`
```
pekko-actor-testkit-typed_2.13
pekko-actor-typed_2.13
pekko-actor_2.13
pekko-bom_2.13
pekko-cluster-metrics_2.13
pekko-cluster-sharding-typed_2.13
pekko-cluster-sharding_2.13
pekko-cluster-tools_2.13
pekko-cluster-typed_2.13
pekko-cluster_2.13
pekko-coordination_2.13
pekko-discovery_2.13
pekko-distributed-data_2.13
pekko-multi-node-testkit_2.13
pekko-osgi_2.13
pekko-persistence-query_2.13
pekko-persistence-tck_2.13
pekko-persistence-testkit_2.13
pekko-persistence-typed_2.13
pekko-persistence_2.13
pekko-pki_2.13
pekko-protobuf-v3_2.13
pekko-protobuf_2.13
pekko-remote_2.13
pekko-serialization-jackson_2.13
pekko-slf4j_2.13
pekko-stream-testkit_2.13
pekko-stream-typed_2.13
pekko-stream_2.13
pekko-testkit_2.13
```
Which means everything is working as expected (if you replace the `pekko-` with `akka-` and put it in an online diff viewer you can see that its exactly the same).
Going to go ahead and merge the PR. Thanks for the help everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#issuecomment-1338986863
TBH, probably my biggest concern is the fact the reliance on sbt's implicit behaviour that if a project `name` is not set then it just uses the project `id` plus the fact that people get the incorrect assumption that a project directory is the same as the project name (which its not, there is no relation whatsoever). As an example when `akka-docs` was renamed to `docs` it created a regression (see https://github.com/apache/incubator-pekko/pull/72) because other code assumed the `akka` prefix.
Having the project name's set explicitly along with different folder names means that these kind of regressions won't happen when refactoring is done.
> One of my key reasons for this is that in the docs, you don't have to worry about whether we need to replace with akka-actor with actor or pekko-actor - because sometimes in the existing docs, akka-actor can refer to a file location and sometimes to the module/jar name.
This to me is a more convincing argument however I actually handled this in the PR albeit I need to do a screening. I might sleep on this for a couple of days, @He-Pin @gmethvin @jrudolph @seglo @spangaer what are your thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#discussion_r1038887167
##########
LICENSE:
##########
@@ -207,6 +207,6 @@ Licenses for dependency projects can be found here:
---------------
-akka-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
+protobuf contains the sources of Google protobuf 2.5.0 runtime support,
Review Comment:
Could this be changed to`pekko-protobuf module contains`? The dir rename makes this statement very ambiguous. The Notice should be use the jar name as opposed to the dir name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#issuecomment-1336398569
@pjfanning Since https://github.com/apache/incubator-pekko-http/pull/11 was merged I am thinking of just maintaining the same dir structure.
Will take a while to update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] seglo commented on pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
seglo commented on PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#issuecomment-1366347715
Since the module and directory names have to change anyway I'm in favour of dropping akka/pekko prefix as defined in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich merged PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#discussion_r1061738668
##########
LICENSE:
##########
@@ -207,6 +207,6 @@ Licenses for dependency projects can be found here:
---------------
-akka-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
+pekko-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
Review Comment:
Sure, this can be updated and made consistent in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
He-Pin commented on code in PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#discussion_r1045017529
##########
build.sbt:
##########
@@ -102,10 +102,10 @@ lazy val root = Project(id = "pekko", base = file("."))
.settings(PekkoBuild.welcomeSettings)
.enablePlugins(CopyrightHeaderForBuild)
-lazy val actor = akkaModule("akka-actor")
+lazy val actor = pekkoModule("actor")
Review Comment:
not `pekko-actor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #71: Rename sbt akka modules
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#discussion_r1045083205
##########
build.sbt:
##########
@@ -102,10 +102,10 @@ lazy val root = Project(id = "pekko", base = file("."))
.settings(PekkoBuild.welcomeSettings)
.enablePlugins(CopyrightHeaderForBuild)
-lazy val actor = akkaModule("akka-actor")
+lazy val actor = pekkoModule("actor")
Review Comment:
So the idea is to remove the `akka-`/`pekko-` prefix for sbt project names because its redundant (not this will not effect the `jar`/artifact, which will still have the `pekko-` prefix). This is however somewhat controversial so I was planning to make a discussion on the mailing list on it (sorry I have been a bit busy lately and this fell off the radar, will try to send off an email by end of the weekned).
##########
build.sbt:
##########
@@ -102,10 +102,10 @@ lazy val root = Project(id = "pekko", base = file("."))
.settings(PekkoBuild.welcomeSettings)
.enablePlugins(CopyrightHeaderForBuild)
-lazy val actor = akkaModule("akka-actor")
+lazy val actor = pekkoModule("actor")
Review Comment:
So the idea is to remove the `akka-`/`pekko-` prefix for sbt project names because its redundant (not this will not effect the `jar`/artifact, which will still have the `pekko-` prefix). This is however somewhat controversial so I was planning to make a discussion on the mailing list on it (sorry I have been a bit busy lately and this fell off the radar, will try to send off an email by end of the weekend).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org