You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2013/01/18 18:33:40 UTC

[3/8] android commit: Removed debugging output.

Removed debugging output.


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/15a5c89e
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/15a5c89e
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/15a5c89e

Branch: refs/heads/master
Commit: 15a5c89e86e2e0cf843fb507659cabfd47199ead
Parents: 03b974e
Author: Braden Shepherdson <br...@chromium.org>
Authored: Tue Jan 15 11:52:06 2013 -0500
Committer: Braden Shepherdson <br...@chromium.org>
Committed: Tue Jan 15 11:52:06 2013 -0500

----------------------------------------------------------------------
 framework/src/org/apache/cordova/BinaryEcho.java   |    5 -----
 .../org/apache/cordova/NativeToJsMessageQueue.java |    8 +-------
 .../src/org/apache/cordova/api/PluginResult.java   |    2 --
 3 files changed, 1 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/15a5c89e/framework/src/org/apache/cordova/BinaryEcho.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/BinaryEcho.java b/framework/src/org/apache/cordova/BinaryEcho.java
index 61f590b..ad7393f 100644
--- a/framework/src/org/apache/cordova/BinaryEcho.java
+++ b/framework/src/org/apache/cordova/BinaryEcho.java
@@ -26,7 +26,6 @@ import org.json.JSONArray;
 import org.json.JSONException;
 
 import android.util.Base64;
-import android.util.Log;
 
 public class BinaryEcho extends CordovaPlugin {
 
@@ -43,15 +42,11 @@ public class BinaryEcho extends CordovaPlugin {
             if (action.equals("echo")) {
                 //CordovaJSONArray cdvArgs = (CordovaJSONArray) args;
                 //byte[] data = cdvArgs.getArrayBuffer(0);
-                Log.i("Braden", "BinaryEcho top");
                 byte[] data = Base64.decode(args.getString(0), Base64.DEFAULT);
-                Log.i("Braden", "byte[] retrieved: " + data.length);
 
                 // Don't return any result now, since status results will be sent when events come in from broadcast receiver
                 PluginResult pluginResult = new PluginResult(PluginResult.Status.OK, data);
-                Log.i("Braden", "PluginResult created");
                 callbackContext.sendPluginResult(pluginResult);
-                Log.i("Braden", "sendPluginResult() complete");
                 return true;
             }
         } catch (JSONException e) {

http://git-wip-us.apache.org/repos/asf/cordova-android/blob/15a5c89e/framework/src/org/apache/cordova/NativeToJsMessageQueue.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/NativeToJsMessageQueue.java b/framework/src/org/apache/cordova/NativeToJsMessageQueue.java
index 27de8ed..83e1778 100755
--- a/framework/src/org/apache/cordova/NativeToJsMessageQueue.java
+++ b/framework/src/org/apache/cordova/NativeToJsMessageQueue.java
@@ -131,12 +131,9 @@ public class NativeToJsMessageQueue {
     
     private void packMessage(JsMessage message, StringBuilder sb) {
         int len = message.calculateEncodedLength();
-        Log.i("Braden", "Length " + len);
         sb.append(len)
           .append(' ');
         message.encodeAsMessage(sb);
-        Log.i("Braden", "End of packMessage");
-        Log.i("Braden", sb.toString());
     }
     
     /**
@@ -455,11 +452,8 @@ public class NativeToJsMessageQueue {
                     sb.append(pluginResult.getStrMessage());
                     break;
                 case PluginResult.MESSAGE_TYPE_ARRAYBUFFER:
-                    Log.i("Braden", "ArrayBuffer response encoding");
                     sb.append('A');
-                    String temp = pluginResult.getMessage();
-                    Log.i("Braden", temp);
-                    sb.append(temp);
+                    sb.append(pluginResult.getMessage());
                     break;
                 case PluginResult.MESSAGE_TYPE_JSON:
                 default:

http://git-wip-us.apache.org/repos/asf/cordova-android/blob/15a5c89e/framework/src/org/apache/cordova/api/PluginResult.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/api/PluginResult.java b/framework/src/org/apache/cordova/api/PluginResult.java
index ddceb42..4c1d833 100755
--- a/framework/src/org/apache/cordova/api/PluginResult.java
+++ b/framework/src/org/apache/cordova/api/PluginResult.java
@@ -22,7 +22,6 @@ import org.json.JSONArray;
 import org.json.JSONObject;
 
 import android.util.Base64;
-import android.util.Log;
 
 public class PluginResult {
     private final int status;
@@ -75,7 +74,6 @@ public class PluginResult {
         this.status = status.ordinal();
         this.messageType = MESSAGE_TYPE_ARRAYBUFFER;
         this.encodedMessage = Base64.encodeToString(data, Base64.NO_WRAP);
-        Log.i("Braden", "Message.length() = " + this.encodedMessage.length());
     }
 
     public void setKeepCallback(boolean b) {