You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/03/06 18:30:32 UTC
[GitHub] [zookeeper] ztzg opened a new pull request #1622: ZOOKEEPER-4232: InvalidSnapshotTest corrupts its own test data
ztzg opened a new pull request #1622:
URL: https://github.com/apache/zookeeper/pull/1622
`InvalidSnapshotTest.testSnapshot` starts an instance of
`ZooKeeperServer` on the version-controlled `resources/data/invalidsnap`
directory, which, as a side-effect, \"fixes\" the following
snapshot—which was broken on purpose (see ZOOKEEPER-367):
`zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f`
This status quo creates a number of problems:
1. It makes the test ineffective after the first run;
2. The file shows as modified in version control tools, which can be
annoying;
3. The \"fixed\" snapshot can end up being committed by mistake,
invalidating the test.
(\#3 is not theoretical; that \"fixed\" snapshot frequently shows up in
pull requests, and was recently merged into master.).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad edited a comment on pull request #1622: ZOOKEEPER-4232: InvalidSnapshotTest corrupts its own test data
Posted by GitBox <gi...@apache.org>.
arshadmohammad edited a comment on pull request #1622:
URL: https://github.com/apache/zookeeper/pull/1622#issuecomment-792875820
Changes look good to me. Please raise PR for other branches as well.
You can raise PR for branch-3.7, I think that PR will apply on branch-3.6 and branch-3.5 also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1622: ZOOKEEPER-4232: InvalidSnapshotTest corrupts its own test data
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1622:
URL: https://github.com/apache/zookeeper/pull/1622#issuecomment-793684555
Thank you for the review, @arshadmohammad.
> Changes look good to me. Please raise PR for other branches as well.
> You can raise PR for branch-3.7, I think that PR will apply on branch-3.6 and branch-3.5 also
No such luck, unfortunately! JUnit's API churn gets in the way… Anyway; here you are:
* `master`: This PR;
* `branch-3.7`, `branch-3.7.0`: https://github.com/apache/zookeeper/pull/1627;
* `branch-3.6`: https://github.com/apache/zookeeper/pull/1628;
* `branch-3.5`: https://github.com/apache/zookeeper/pull/1629.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1622: ZOOKEEPER-4232: InvalidSnapshotTest corrupts its own test data
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1622:
URL: https://github.com/apache/zookeeper/pull/1622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad commented on pull request #1622: ZOOKEEPER-4232: InvalidSnapshotTest corrupts its own test data
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1622:
URL: https://github.com/apache/zookeeper/pull/1622#issuecomment-792875820
Changes look good to me. Please raise PR for branches as well.
You can raise PR for branch-3.7, I think that PR will apply on branch-3.6 and branch-3.5 also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org