You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/19 09:56:31 UTC
[GitHub] [airflow] mik-laj opened a new pull request #9402: Restore airflow.www.app.csrf to avoid breaking change
mik-laj opened a new pull request #9402:
URL: https://github.com/apache/airflow/pull/9402
This field has been deleted in https://github.com/apache/airflow/pull/9291/files
There was no described reason why this should be initialized at the module level, but @ash noted that users use it in their own plugins.
Slack conversation: https://apache-airflow.slack.com/archives/CCR6P6JRL/p1592553233200300
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9402: Restore airflow.www.app.csrf to avoid breaking change
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9402:
URL: https://github.com/apache/airflow/pull/9402#discussion_r442902242
##########
File path: docs/plugins.rst
##########
@@ -253,6 +253,20 @@ Airflow 1.10 introduced role based views using FlaskAppBuilder. You can configur
``rbac = True``. To support plugin views and links for both versions of the UI and maintain backwards compatibility,
the fields ``appbuilder_views`` and ``appbuilder_menu_items`` were added to the ``AirflowTestPlugin`` class.
+Exclude views from CSRF protection
+----------------------------------
+
+We strongly suggest that you protect all your views with CSRF. But if needed, you can exclude
Review comment:
```suggestion
We strongly suggest that you should protect all your views with CSRF. But if needed, you can exclude
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #9402: Restore airflow.www.app.csrf to avoid breaking change
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #9402:
URL: https://github.com/apache/airflow/pull/9402
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org