You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by we...@apache.org on 2016/01/04 20:34:59 UTC
reef git commit: [REEF-1097] Pass through O.A.R.Utilities to hide
unnecessarily public APIs
Repository: reef
Updated Branches:
refs/heads/master 9ed4f4f7d -> 91bec702e
[REEF-1097] Pass through O.A.R.Utilities to hide unnecessarily public APIs
JIRA:
[REEF-1097](https://issues.apache.org/jira/browse/REEF-1097)
Pull Request:
This closes #749
Project: http://git-wip-us.apache.org/repos/asf/reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/91bec702
Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/91bec702
Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/91bec702
Branch: refs/heads/master
Commit: 91bec702e28eb97ef620bd3bcc6680ffa7ceac3d
Parents: 9ed4f4f
Author: Andrew Chung <af...@apache.org>
Authored: Wed Dec 23 10:26:51 2015 -0800
Committer: Markus Weimer <we...@apache.org>
Committed: Mon Jan 4 11:33:45 2016 -0800
----------------------------------------------------------------------
lang/cs/Org.Apache.REEF.Utilities/AvroUtils.cs | 4 +++-
.../Org.Apache.REEF.Utilities/Diagnostics/DiagnosticsMessages.cs | 2 +-
lang/cs/Org.Apache.REEF.Utilities/Diagnostics/Exceptions.cs | 2 ++
lang/cs/Org.Apache.REEF.Utilities/Logging/Logger.cs | 2 +-
lang/cs/Org.Apache.REEF.Utilities/NetUtilities.cs | 2 +-
lang/cs/Org.Apache.REEF.Utilities/ValidationUtilities.cs | 2 +-
6 files changed, 9 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/reef/blob/91bec702/lang/cs/Org.Apache.REEF.Utilities/AvroUtils.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Utilities/AvroUtils.cs b/lang/cs/Org.Apache.REEF.Utilities/AvroUtils.cs
index b131c1f..ce68f4b 100644
--- a/lang/cs/Org.Apache.REEF.Utilities/AvroUtils.cs
+++ b/lang/cs/Org.Apache.REEF.Utilities/AvroUtils.cs
@@ -19,10 +19,12 @@
using System.IO;
using Microsoft.Hadoop.Avro;
+using Org.Apache.REEF.Utilities.Attributes;
namespace Org.Apache.REEF.Utilities
{
- public class AvroUtils
+ [Private]
+ public static class AvroUtils
{
/// <summary>
/// Convert an object to byte array using Avro serializiation
http://git-wip-us.apache.org/repos/asf/reef/blob/91bec702/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/DiagnosticsMessages.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/DiagnosticsMessages.cs b/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/DiagnosticsMessages.cs
index 8c54b4b..faf59b6 100644
--- a/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/DiagnosticsMessages.cs
+++ b/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/DiagnosticsMessages.cs
@@ -19,7 +19,7 @@
namespace Org.Apache.REEF.Utilities.Diagnostics
{
- public class DiagnosticsMessages
+ internal static class DiagnosticsMessages
{
public const string ExceptionThrowing = "ExceptionThrowing";
http://git-wip-us.apache.org/repos/asf/reef/blob/91bec702/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/Exceptions.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/Exceptions.cs b/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/Exceptions.cs
index 627f239..6d22eb2 100644
--- a/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/Exceptions.cs
+++ b/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/Exceptions.cs
@@ -21,9 +21,11 @@ using System;
using System.Runtime.ExceptionServices;
using System.Text;
using Org.Apache.REEF.Utilities.Logging;
+using Org.Apache.REEF.Utilities.Attributes;
namespace Org.Apache.REEF.Utilities.Diagnostics
{
+ [Private]
public static class Exceptions
{
#region methods
http://git-wip-us.apache.org/repos/asf/reef/blob/91bec702/lang/cs/Org.Apache.REEF.Utilities/Logging/Logger.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Utilities/Logging/Logger.cs b/lang/cs/Org.Apache.REEF.Utilities/Logging/Logger.cs
index 5d9fc67..488163c 100644
--- a/lang/cs/Org.Apache.REEF.Utilities/Logging/Logger.cs
+++ b/lang/cs/Org.Apache.REEF.Utilities/Logging/Logger.cs
@@ -25,7 +25,7 @@ using System.Globalization;
namespace Org.Apache.REEF.Utilities.Logging
{
// TODO[REEF-842] Act on the obsoletes
- public class Logger
+ public sealed class Logger
{
private static readonly string[] LogLevel = new string[]
{
http://git-wip-us.apache.org/repos/asf/reef/blob/91bec702/lang/cs/Org.Apache.REEF.Utilities/NetUtilities.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Utilities/NetUtilities.cs b/lang/cs/Org.Apache.REEF.Utilities/NetUtilities.cs
index c8e3f55..7cc4b36 100644
--- a/lang/cs/Org.Apache.REEF.Utilities/NetUtilities.cs
+++ b/lang/cs/Org.Apache.REEF.Utilities/NetUtilities.cs
@@ -24,7 +24,7 @@ using Org.Apache.REEF.Utilities.Logging;
namespace Org.Apache.REEF.Utilities
{
- public class NetUtilities
+ public static class NetUtilities
{
private static readonly Logger LOGGER = Logger.GetLogger(typeof(NetUtilities));
http://git-wip-us.apache.org/repos/asf/reef/blob/91bec702/lang/cs/Org.Apache.REEF.Utilities/ValidationUtilities.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Utilities/ValidationUtilities.cs b/lang/cs/Org.Apache.REEF.Utilities/ValidationUtilities.cs
index 80507fc..a1daec1 100644
--- a/lang/cs/Org.Apache.REEF.Utilities/ValidationUtilities.cs
+++ b/lang/cs/Org.Apache.REEF.Utilities/ValidationUtilities.cs
@@ -23,7 +23,7 @@ using Org.Apache.REEF.Utilities.Logging;
namespace Org.Apache.REEF.Utilities
{
- public class ValidationUtilities
+ public static class ValidationUtilities
{
private static readonly Logger LOGGER = Logger.GetLogger(typeof(ValidationUtilities));