You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/07/30 19:17:43 UTC

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #947: add unit tests for ConsoleAppender direct mode

ppkarwasz commented on PR #947:
URL: https://github.com/apache/logging-log4j2/pull/947#issuecomment-1200280092

   Hi @sullis,
   
   I admit I don't really see the point of just adding a test case, unless it solves a problem. Besides your test does not check if the appender uses a `FileOutputStream` attached to the file descriptor 1 and 2, it just shows that `System.out` and `System.err` are not used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org