You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/10/09 09:40:26 UTC

[GitHub] [submarine] MortalHappiness opened a new pull request #771: SUBMARINE-1038. Replace submarine helm chart with submarine operator helm chart

MortalHappiness opened a new pull request #771:
URL: https://github.com/apache/submarine/pull/771


   ### What is this PR for?
   Replace submarine helm chart with submarine operator helm chart for consistency when developing helm charts.
   
   ### What type of PR is it?
   [Improvement]
   
   ### Todos
   * [x] - Ensure that the submarine operator creates the same resources as the original submarine helm chart does
   * [x] - Replace submarine helm chart with submarine operator helm chart
   * [x] - Make sure that k8s and python-sdk integration tests are still passed
   * [x] - Update the corresponding documentations
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1038
   
   ### How should this be tested?
   https://github.com/MortalHappiness/submarine/actions/runs/1323214761
   https://github.com/MortalHappiness/submarine/actions/runs/1323214760
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] Kenchu123 edited a comment on pull request #771: SUBMARINE-1038. Replace submarine helm chart with submarine operator helm chart

Posted by GitBox <gi...@apache.org>.
Kenchu123 edited a comment on pull request #771:
URL: https://github.com/apache/submarine/pull/771#issuecomment-943413461


   I am working on [SUBMARINE-1054](https://issues.apache.org/jira/browse/SUBMARINE-1054) to refactor the submarine operator. I will make the submarine operator read YAML files, so that others can change the setup without modifying the operator code.
   
   This PR may be postponed after refactoring. Thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] MortalHappiness commented on pull request #771: SUBMARINE-1038. Replace submarine helm chart with submarine operator helm chart

Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #771:
URL: https://github.com/apache/submarine/pull/771#issuecomment-977520948


   @pingsutw I have resolved the conflict. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #771: SUBMARINE-1038. Replace submarine helm chart with submarine operator helm chart

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #771:
URL: https://github.com/apache/submarine/pull/771


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] Kenchu123 commented on pull request #771: SUBMARINE-1038. Replace submarine helm chart with submarine operator helm chart

Posted by GitBox <gi...@apache.org>.
Kenchu123 commented on pull request #771:
URL: https://github.com/apache/submarine/pull/771#issuecomment-943413461


   I am working on [SUBMARINE-1054](https://issues.apache.org/jira/browse/SUBMARINE-1054) to refactor the submarine operator. I will make the submarine operator read YAML files, so that others can change the setup without modifying the operator code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org