You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Eric Hanson <eh...@microsoft.com> on 2013/12/17 01:01:52 UTC

Review Request 16307: Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16307/
-----------------------------------------------------------

Review request for hive and Gunther Hagleitner.


Bugs: HIVE-6017
    https://issues.apache.org/jira/browse/HIVE-6017


Repository: hive-git


Description
-------

Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive


Diffs
-----

  common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/SignedInt128.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/SqlMathUtil.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/Decimal128Test.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/SignedInt128Test.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/SqlMathUtilTest.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/UnsignedInt128Test.java PRE-CREATION 

Diff: https://reviews.apache.org/r/16307/diff/


Testing
-------


Thanks,

Eric Hanson


Re: Review Request 16307: Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive

Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16307/
-----------------------------------------------------------

(Updated Dec. 17, 2013, 2:12 a.m.)


Review request for hive and Gunther Hagleitner.


Changes
-------

removed trailing white space


Bugs: HIVE-6017
    https://issues.apache.org/jira/browse/HIVE-6017


Repository: hive-git


Description
-------

Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/SignedInt128.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/SqlMathUtil.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestSignedInt128.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestSqlMathUtil.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java PRE-CREATION 

Diff: https://reviews.apache.org/r/16307/diff/


Testing
-------


Thanks,

Eric Hanson


Re: Review Request 16307: Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive

Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16307/
-----------------------------------------------------------

(Updated Dec. 17, 2013, 1:52 a.m.)


Review request for hive and Gunther Hagleitner.


Changes
-------

Tweaked comment spacing and copyright.


Bugs: HIVE-6017
    https://issues.apache.org/jira/browse/HIVE-6017


Repository: hive-git


Description
-------

Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/SignedInt128.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/SqlMathUtil.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestSignedInt128.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestSqlMathUtil.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java PRE-CREATION 

Diff: https://reviews.apache.org/r/16307/diff/


Testing
-------


Thanks,

Eric Hanson


Re: Review Request 16307: Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive

Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16307/
-----------------------------------------------------------

(Updated Dec. 17, 2013, 1:03 a.m.)


Review request for hive and Gunther Hagleitner.


Changes
-------

Fixed test class names to start with Test.


Bugs: HIVE-6017
    https://issues.apache.org/jira/browse/HIVE-6017


Repository: hive-git


Description
-------

Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/SignedInt128.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/SqlMathUtil.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestSignedInt128.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestSqlMathUtil.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java PRE-CREATION 

Diff: https://reviews.apache.org/r/16307/diff/


Testing
-------


Thanks,

Eric Hanson


Re: Review Request 16307: Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16307/#review30503
-----------------------------------------------------------


FYI PTest required tests start with Test not end with it.

- Brock Noland


On Dec. 17, 2013, 12:01 a.m., Eric Hanson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16307/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2013, 12:01 a.m.)
> 
> 
> Review request for hive and Gunther Hagleitner.
> 
> 
> Bugs: HIVE-6017
>     https://issues.apache.org/jira/browse/HIVE-6017
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/type/SignedInt128.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/type/SqlMathUtil.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java PRE-CREATION 
>   common/src/test/org/apache/hadoop/hive/common/type/Decimal128Test.java PRE-CREATION 
>   common/src/test/org/apache/hadoop/hive/common/type/SignedInt128Test.java PRE-CREATION 
>   common/src/test/org/apache/hadoop/hive/common/type/SqlMathUtilTest.java PRE-CREATION 
>   common/src/test/org/apache/hadoop/hive/common/type/UnsignedInt128Test.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eric Hanson
> 
>