You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2010/09/02 17:30:53 UTC

[jira] Created: (TOMAHAWK-1545) Components inside detailStamp facet requires clientId reset each time setRowIndex is called

Components inside detailStamp facet requires clientId reset each time setRowIndex is called
-------------------------------------------------------------------------------------------

                 Key: TOMAHAWK-1545
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1545
             Project: MyFaces Tomahawk
          Issue Type: Bug
          Components: Extended Datatable
    Affects Versions: 1.1.9
            Reporter: Leonardo Uribe
            Assignee: Leonardo Uribe


Checking detailStamp behavior, it was found that sometimes setRowIndex does not reset clientId field using UIComponent.setId(getId()), which could cause problems with invokeOnComponent/visitTree algorithm.

It was also found that we have some code on processDetails(FacesContext, int) that saves the state of the row, that it is no longer necessary by the fix done on TOMAHAWK-1534. I think it is better instead save detailStamp state in AbstractHtmlDataTable, change the iterator overriding saveDescendantComponentStates() and restoreDescendantComponentStates(Object state), and on jsf 1.1 and 1.2 branches remove the hack for prevent processing detailStamp removing and adding from facets map.

We can also remove the hack for deleteRowStateForRow() on AbstractHtmlDataTable, because since the state will be in just one place, this problem is already handled on HtmlDataTableHack

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TOMAHAWK-1545) Components inside detailStamp facet requires clientId reset each time setRowIndex is called

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved TOMAHAWK-1545.
--------------------------------------

    Fix Version/s: 1.1.10-SNAPSHOT
       Resolution: Fixed

> Components inside detailStamp facet requires clientId reset each time setRowIndex is called
> -------------------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1545
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1545
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.9
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.10-SNAPSHOT
>
>
> Checking detailStamp behavior, it was found that sometimes setRowIndex does not reset clientId field using UIComponent.setId(getId()), which could cause problems with invokeOnComponent/visitTree algorithm.
> It was also found that we have some code on processDetails(FacesContext, int) that saves the state of the row, that it is no longer necessary by the fix done on TOMAHAWK-1534. I think it is better instead save detailStamp state in AbstractHtmlDataTable, change the iterator overriding saveDescendantComponentStates() and restoreDescendantComponentStates(Object state), and on jsf 1.1 and 1.2 branches remove the hack for prevent processing detailStamp removing and adding from facets map.
> We can also remove the hack for deleteRowStateForRow() on AbstractHtmlDataTable, because since the state will be in just one place, this problem is already handled on HtmlDataTableHack

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.