[GitHub] [spark] rxin commented on a change in pull request #24110: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files

[GitBox <gi...@apache.org>]

rxin commented on a change in pull request #24110: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24110#discussion_r273324907
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/storage/BlockId.scala
 ##########
 @@ -98,14 +128,18 @@ private[spark] case class TestBlockId(id: String) extends BlockId {
 
 @DeveloperApi
 class UnrecognizedBlockId(name: String)
-    extends SparkException(s"Failed to parse $name into a block ID")
+  extends SparkException(s"Failed to parse $name into a block ID")
 
 @DeveloperApi
 object BlockId {
   val RDD = "rdd_([0-9]+)_([0-9]+)".r
   val SHUFFLE = "shuffle_([0-9]+)_([0-9]+)_([0-9]+)".r
   val SHUFFLE_DATA = "shuffle_([0-9]+)_([0-9]+)_([0-9]+).data".r
   val SHUFFLE_INDEX = "shuffle_([0-9]+)_([0-9]+)_([0-9]+).index".r
+  // the extend shuffle/data/index is only used when INDETERMINATE stage rerun
+  val EXTEND_SHUFFLE = "shuffle_([0-9]+)_([0-9]+)_([0-9]+)_([0-9]+)".r
 
 Review comment:
   please comment and explain what EXTEND_SHUFFLE means.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org