You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/02/29 20:26:19 UTC

[kudu-CR] [java] methods for setting run-time flags via test harness

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21093


Change subject: [java] methods for setting run-time flags via test harness
......................................................................

[java] methods for setting run-time flags via test harness

When I was trying to reproduce an issue seen in the field, I found
that necessary functionality was missing in the Java test harness.
This patch addresses the deficiency, introducing the corresponding
methods to set run-time flags for Kudu masters and tablet servers.
This patch also updates the test harness class to provides a means
to restart a tablet server that hosts a particular tablet replica.

Change-Id: I5ed12b2ef9fd077534528361f6bb42efe3730182
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
1 file changed, 35 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/21093/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ed12b2ef9fd077534528361f6bb42efe3730182
Gerrit-Change-Number: 21093
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [java] methods for setting run-time flags via test harness

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21093 )

Change subject: [java] methods for setting run-time flags via test harness
......................................................................

[java] methods for setting run-time flags via test harness

When I was trying to reproduce an issue seen in the field, I found
that necessary functionality was missing in the Java test harness.
This patch addresses the deficiency, introducing the corresponding
methods to set run-time flags for Kudu masters and tablet servers.
This patch also updates the test harness class to provides a means
to restart a tablet server that hosts a particular tablet replica.

Change-Id: I5ed12b2ef9fd077534528361f6bb42efe3730182
Reviewed-on: http://gerrit.cloudera.org:8080/21093
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
1 file changed, 35 insertions(+), 0 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ed12b2ef9fd077534528361f6bb42efe3730182
Gerrit-Change-Number: 21093
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] methods for setting run-time flags via test harness

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21093 )

Change subject: [java] methods for setting run-time flags via test harness
......................................................................


Patch Set 1: Verified+1

unrelated test failure in RaftConsensusITest.TestSlowFollower


-- 
To view, visit http://gerrit.cloudera.org:8080/21093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed12b2ef9fd077534528361f6bb42efe3730182
Gerrit-Change-Number: 21093
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Mar 2024 01:32:19 +0000
Gerrit-HasComments: No

[kudu-CR] [java] methods for setting run-time flags via test harness

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [java] methods for setting run-time flags via test harness
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5ed12b2ef9fd077534528361f6bb42efe3730182
Gerrit-Change-Number: 21093
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] methods for setting run-time flags via test harness

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21093 )

Change subject: [java] methods for setting run-time flags via test harness
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed12b2ef9fd077534528361f6bb42efe3730182
Gerrit-Change-Number: 21093
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Mar 2024 00:53:45 +0000
Gerrit-HasComments: No