You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/07/29 07:20:01 UTC

[jira] [Commented] (GEODE-8384) SETEX error message should be consistent with native redis

    [ https://issues.apache.org/jira/browse/GEODE-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166966#comment-17166966 ] 

ASF GitHub Bot commented on GEODE-8384:
---------------------------------------

dschneider-pivotal opened a new pull request #5402:
URL: https://github.com/apache/geode/pull/5402


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> SETEX error message should be consistent with native redis
> ----------------------------------------------------------
>
>                 Key: GEODE-8384
>                 URL: https://issues.apache.org/jira/browse/GEODE-8384
>             Project: Geode
>          Issue Type: Bug
>          Components: redis
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>            Priority: Major
>
> When we pass a negative expiration to SETEX on native redis we get the following error message:
>  
> {{ERR invalid expire time in setex}}
> When we pass a negative expiration to SETEX on geode redis we get the following error message:
>  
> {{ERR The expiration argument must be greater than 0}}
> These error messages should match.
> Revert the following native Redis test back to its original form:
>  
> {{test \{SETEX - Wrong time parameter}}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)