You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2019/08/14 14:56:25 UTC

[flink] branch release-1.9 updated (f4af5a8 -> ae1effc)

This is an automated email from the ASF dual-hosted git repository.

trohrmann pushed a change to branch release-1.9
in repository https://gitbox.apache.org/repos/asf/flink.git.


    from f4af5a8  [FLINK-13663][e2e] Double curl retries count and total time for Kafka downloads
     new c87dcac  [FLINK-13585][tests] Harden TaskAsyncCallTest by fixing race condition
     new ae1effc  [hotfix][tests] Fix code style error of TaskAsyncCallTest

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../flink/runtime/taskmanager/TaskAsyncCallTest.java       | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)


[flink] 02/02: [hotfix][tests] Fix code style error of TaskAsyncCallTest

Posted by tr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

trohrmann pushed a commit to branch release-1.9
in repository https://gitbox.apache.org/repos/asf/flink.git

commit ae1effc4deb1870c5109dd86ec60bd94e97d09b3
Author: ifndef-SleePy <mm...@gmail.com>
AuthorDate: Wed Aug 14 20:51:08 2019 +0800

    [hotfix][tests] Fix code style error of TaskAsyncCallTest
---
 .../apache/flink/runtime/taskmanager/TaskAsyncCallTest.java    | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
index ef1d816..efd7ddb 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
@@ -41,9 +41,7 @@ import org.apache.flink.runtime.executiongraph.TaskInformation;
 import org.apache.flink.runtime.filecache.FileCache;
 import org.apache.flink.runtime.io.disk.iomanager.IOManager;
 import org.apache.flink.runtime.io.network.NettyShuffleEnvironmentBuilder;
-import org.apache.flink.runtime.shuffle.ShuffleEnvironment;
 import org.apache.flink.runtime.io.network.TaskEventDispatcher;
-import org.apache.flink.runtime.taskexecutor.PartitionProducerStateChecker;
 import org.apache.flink.runtime.io.network.partition.NoOpResultPartitionConsumableNotifier;
 import org.apache.flink.runtime.io.network.partition.ResultPartitionConsumableNotifier;
 import org.apache.flink.runtime.jobgraph.JobVertexID;
@@ -53,8 +51,10 @@ import org.apache.flink.runtime.memory.MemoryManager;
 import org.apache.flink.runtime.metrics.groups.TaskMetricGroup;
 import org.apache.flink.runtime.metrics.groups.UnregisteredMetricGroups;
 import org.apache.flink.runtime.query.KvStateRegistry;
+import org.apache.flink.runtime.shuffle.ShuffleEnvironment;
 import org.apache.flink.runtime.state.TestTaskStateManager;
 import org.apache.flink.runtime.taskexecutor.KvStateService;
+import org.apache.flink.runtime.taskexecutor.PartitionProducerStateChecker;
 import org.apache.flink.runtime.taskexecutor.TestGlobalAggregateManager;
 import org.apache.flink.runtime.util.TestingTaskManagerRuntimeInfo;
 import org.apache.flink.util.SerializedValue;
@@ -80,6 +80,9 @@ import static org.mockito.Matchers.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+/**
+ * Testing asynchronous call of {@link Task}.
+ */
 public class TaskAsyncCallTest extends TestLogger {
 
 	/** Number of expected checkpoints. */
@@ -265,6 +268,9 @@ public class TaskAsyncCallTest extends TestLogger {
 			executor);
 	}
 
+	/**
+	 * Invokable for testing checkpoints.
+	 */
 	public static class CheckpointsInOrderInvokable extends AbstractInvokable {
 
 		private volatile long lastCheckpointId = 0;


[flink] 01/02: [FLINK-13585][tests] Harden TaskAsyncCallTest by fixing race condition

Posted by tr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

trohrmann pushed a commit to branch release-1.9
in repository https://gitbox.apache.org/repos/asf/flink.git

commit c87dcac6fb6ed99faae38108023f8633e7a0f255
Author: ifndef-SleePy <mm...@gmail.com>
AuthorDate: Wed Aug 14 20:46:52 2019 +0800

    [FLINK-13585][tests] Harden TaskAsyncCallTest by fixing race condition
    
    This closes #9436.
---
 .../java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
index f7b366b..ef1d816 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
@@ -196,9 +196,9 @@ public class TaskAsyncCallTest extends TestLogger {
 			triggerLatch.await();
 
 			task.notifyCheckpointComplete(1);
-			task.cancelExecution();
-
 			notifyCheckpointCompleteLatch.await();
+
+			task.cancelExecution();
 			stopLatch.await();
 
 			assertThat(classLoaders, hasSize(greaterThanOrEqualTo(2)));