[GitHub] [spark] juliuszsompolski commented on a diff in pull request #42465: [CONNECT][POC] Have real server and real simple client in tests - connect-client-jvm-shaded

["juliuszsompolski (via GitHub)" <gi...@apache.org>]

juliuszsompolski commented on code in PR #42465:
URL: https://github.com/apache/spark/pull/42465#discussion_r1291914360


##########
connector/connect/server/pom.xml:
##########
@@ -140,6 +140,21 @@
         </exclusion>
       </exclusions>
     </dependency>
+    <dependency>
+      <!--
+      We only need classes from org.apache.spark.sql.connect for testing.
+      spark-connect-client-jvm also contain the client versions of org.apache.spark.sql classes
+      that are also present in spark-sql,
+      e.g. org.apache.spark.sql.SparkSession, org.apache.spark.sql.Dataset.
+      However, since Maven 2.0.9, Maven uses the order of dependencies in the POM to build the
+      classpath, so this dependency is below spark-sql dependency is above, the classes from the
+      server should take precedence.
+      -->
+      <groupId>org.apache.spark</groupId>
+      <artifactId>spark-connect-client-jvm_${scala.binary.version}</artifactId>
+      <version>${project.version}</version>
+      <scope>test</scope>
+    </dependency>

Review Comment:
   @LuciferYang @HyukjinKwon @hvanhovell @vicennial @grundprinzip
   Could it just actually work? Seems to work for me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org