You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/09/17 00:46:45 UTC

[GitHub] [openwhisk-website] yasinghcse opened a new pull request #445: Update example

yasinghcse opened a new pull request #445:
URL: https://github.com/apache/openwhisk-website/pull/445


   **Changes:**
   - Update nodejs client examples
   ![Screen Shot 2020-09-16 at 8 36 29 PM](https://user-images.githubusercontent.com/20551578/93406452-b032fd00-f85d-11ea-8a1c-8e20d671c3e8.png)
   
   
   
   - Update invoke action commands to use common flags for all examples


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] yasinghcse commented on a change in pull request #445: Update example

Posted by GitBox <gi...@apache.org>.
yasinghcse commented on a change in pull request #445:
URL: https://github.com/apache/openwhisk-website/pull/445#discussion_r490638012



##########
File path: _layouts/documentation.html
##########
@@ -872,18 +872,14 @@ <h5>Creating and Invoking NodeJS actions</h5>
               </div>
             </li>
             <li style="list-style-type: decimal">
-              Invoke the <i>helloJS</i> action as a blocking activation:
+              Invoke an action <i>helloJS</i>:
               <div class="terminal">
-{% highlight bash %}$ wsk action invoke helloJS --blocking{% endhighlight %}
+{% highlight bash %}$ wsk action invoke helloJS -r -p name World{% endhighlight %}

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] rabbah merged pull request #445: Update example

Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #445:
URL: https://github.com/apache/openwhisk-website/pull/445


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] rabbah commented on a change in pull request #445: Update example

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #445:
URL: https://github.com/apache/openwhisk-website/pull/445#discussion_r490237123



##########
File path: _layouts/documentation.html
##########
@@ -1087,7 +1083,7 @@ <h5>Creating And Invoking Python actions</h5>
             </li>
             <li style="list-style-type: decimal">Invoke the <i>helloPy</i> action using command-line parameters:
               <div class="terminal">
-{% highlight bash %}$ wsk action invoke helloPy --blocking --param name World{% endhighlight %}
+{% highlight bash %}$ wsk action invoke helloPy -r -p name World{% endhighlight %}

Review comment:
       ```suggestion
   {% highlight bash %}$ wsk action invoke helloPy --result --param name World{% endhighlight %}
   ```

##########
File path: _layouts/documentation.html
##########
@@ -872,18 +872,14 @@ <h5>Creating and Invoking NodeJS actions</h5>
               </div>
             </li>
             <li style="list-style-type: decimal">
-              Invoke the <i>helloJS</i> action as a blocking activation:
+              Invoke an action <i>helloJS</i>:
               <div class="terminal">
-{% highlight bash %}$ wsk action invoke helloJS --blocking{% endhighlight %}
+{% highlight bash %}$ wsk action invoke helloJS -r -p name World{% endhighlight %}

Review comment:
       ```suggestion
   {% highlight bash %}$ wsk action invoke helloJS --result --param name World{% endhighlight %}
   ```

##########
File path: _layouts/documentation.html
##########
@@ -1212,7 +1208,7 @@ <h5>Creating and Invoking Java actions</h5>
             <li style="list-style-type: decimal">
               Invoke an action <i>helloJava</i>:
               <div class="terminal">
-{% highlight bash %}$ wsk action invoke helloJava --blocking --result{% endhighlight %}
+{% highlight bash %}$ wsk action invoke helloJava -r{% endhighlight %}

Review comment:
       ```suggestion
   {% highlight bash %}$ wsk action invoke helloJava --result{% endhighlight %}
   ```

##########
File path: _layouts/documentation.html
##########
@@ -1396,7 +1392,7 @@ <h5>Creating and Invoking Ruby actions</h5>
             <li style="list-style-type: decimal">
               Invoke an action <i>hello_ruby</i>:
               <div class="terminal">
-{% highlight bash %}$ wsk action invoke hello_ruby --blocking --result --param name World{% endhighlight %}
+{% highlight bash %}$ wsk action invoke hello_ruby -r -p name World{% endhighlight %}

Review comment:
       ```suggestion
   {% highlight bash %}$ wsk action invoke hello_ruby --result --param name World{% endhighlight %}
   ```

##########
File path: _layouts/documentation.html
##########
@@ -1290,7 +1286,7 @@ <h5>Creating and Invoking PHP actions</h5>
             <li style="list-style-type: decimal">
               Invoke an action <i>helloPHP</i>:
               <div class="terminal">
-{% highlight bash %}$ wsk action invoke helloPHP --blocking --result --param name World{% endhighlight %}
+{% highlight bash %}$ wsk action invoke helloPHP -r -p name World{% endhighlight %}

Review comment:
       ```suggestion
   {% highlight bash %}$ wsk action invoke helloPHP --result --param name World{% endhighlight %}
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] rabbah commented on pull request #445: Update example

Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #445:
URL: https://github.com/apache/openwhisk-website/pull/445#issuecomment-694927453


   Thank you @yasinghcse.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] yasinghcse edited a comment on pull request #445: Update example

Posted by GitBox <gi...@apache.org>.
yasinghcse edited a comment on pull request #445:
URL: https://github.com/apache/openwhisk-website/pull/445#issuecomment-694580737


   @rabbah All example updates to use --param and --result flag.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] yasinghcse commented on a change in pull request #445: Update example

Posted by GitBox <gi...@apache.org>.
yasinghcse commented on a change in pull request #445:
URL: https://github.com/apache/openwhisk-website/pull/445#discussion_r490638012



##########
File path: _layouts/documentation.html
##########
@@ -872,18 +872,14 @@ <h5>Creating and Invoking NodeJS actions</h5>
               </div>
             </li>
             <li style="list-style-type: decimal">
-              Invoke the <i>helloJS</i> action as a blocking activation:
+              Invoke an action <i>helloJS</i>:
               <div class="terminal">
-{% highlight bash %}$ wsk action invoke helloJS --blocking{% endhighlight %}
+{% highlight bash %}$ wsk action invoke helloJS -r -p name World{% endhighlight %}

Review comment:
       Added the changes under a new commit.

##########
File path: _layouts/documentation.html
##########
@@ -1087,7 +1083,7 @@ <h5>Creating And Invoking Python actions</h5>
             </li>
             <li style="list-style-type: decimal">Invoke the <i>helloPy</i> action using command-line parameters:
               <div class="terminal">
-{% highlight bash %}$ wsk action invoke helloPy --blocking --param name World{% endhighlight %}
+{% highlight bash %}$ wsk action invoke helloPy -r -p name World{% endhighlight %}

Review comment:
       Added the changes under a new commit

##########
File path: _layouts/documentation.html
##########
@@ -1212,7 +1208,7 @@ <h5>Creating and Invoking Java actions</h5>
             <li style="list-style-type: decimal">
               Invoke an action <i>helloJava</i>:
               <div class="terminal">
-{% highlight bash %}$ wsk action invoke helloJava --blocking --result{% endhighlight %}
+{% highlight bash %}$ wsk action invoke helloJava -r{% endhighlight %}

Review comment:
       Added the changes under a new commit

##########
File path: _layouts/documentation.html
##########
@@ -1290,7 +1286,7 @@ <h5>Creating and Invoking PHP actions</h5>
             <li style="list-style-type: decimal">
               Invoke an action <i>helloPHP</i>:
               <div class="terminal">
-{% highlight bash %}$ wsk action invoke helloPHP --blocking --result --param name World{% endhighlight %}
+{% highlight bash %}$ wsk action invoke helloPHP -r -p name World{% endhighlight %}

Review comment:
       Added the changes under a new commit

##########
File path: _layouts/documentation.html
##########
@@ -1396,7 +1392,7 @@ <h5>Creating and Invoking Ruby actions</h5>
             <li style="list-style-type: decimal">
               Invoke an action <i>hello_ruby</i>:
               <div class="terminal">
-{% highlight bash %}$ wsk action invoke hello_ruby --blocking --result --param name World{% endhighlight %}
+{% highlight bash %}$ wsk action invoke hello_ruby -r -p name World{% endhighlight %}

Review comment:
       Added the changes under a new commit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] yasinghcse commented on pull request #445: Update example

Posted by GitBox <gi...@apache.org>.
yasinghcse commented on pull request #445:
URL: https://github.com/apache/openwhisk-website/pull/445#issuecomment-694580737


   All example updates to use --param and --result flag.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org