You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/14 17:53:38 UTC

[GitHub] [incubator-pinot] jihaozh opened a new pull request #5865: [TE] anomaly search - hide child anomaly unless queried with anomaly ids

jihaozh opened a new pull request #5865:
URL: https://github.com/apache/incubator-pinot/pull/5865


   Previously, the child anomalies will be hidden from the anomalies page. However, if clicked from an entity alert email, it requires showing those anomalies. This PR fixes the issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5865: [TE] anomaly search - hide child anomaly unless queried with anomaly ids

Posted by GitBox <gi...@apache.org>.
jihaozh commented on a change in pull request #5865:
URL: https://github.com/apache/incubator-pinot/pull/5865#discussion_r471750805



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/anomalies/AnomalySearcher.java
##########
@@ -70,7 +70,11 @@ public AnomalySearcher() {
    * @return the result
    */
   public Map<String, Object> search(AnomalySearchFilter searchFilter, int limit, int offset) {
-    Predicate predicate = Predicate.EQ("child", false);
+    Predicate predicate = Predicate.NEQ("baseId", 0);

Review comment:
       thanks, added the comment
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5865: [TE] anomaly search - hide child anomaly unless queried with anomaly ids

Posted by GitBox <gi...@apache.org>.
vincentchenjl commented on a change in pull request #5865:
URL: https://github.com/apache/incubator-pinot/pull/5865#discussion_r471688111



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/anomalies/AnomalySearcher.java
##########
@@ -70,7 +70,11 @@ public AnomalySearcher() {
    * @return the result
    */
   public Map<String, Object> search(AnomalySearchFilter searchFilter, int limit, int offset) {
-    Predicate predicate = Predicate.EQ("child", false);
+    Predicate predicate = Predicate.NEQ("baseId", 0);

Review comment:
       +1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5865: [TE] anomaly search - hide child anomaly unless queried with anomaly ids

Posted by GitBox <gi...@apache.org>.
akshayrai commented on a change in pull request #5865:
URL: https://github.com/apache/incubator-pinot/pull/5865#discussion_r471180552



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/anomalies/AnomalySearcher.java
##########
@@ -70,7 +70,11 @@ public AnomalySearcher() {
    * @return the result
    */
   public Map<String, Object> search(AnomalySearchFilter searchFilter, int limit, int offset) {
-    Predicate predicate = Predicate.EQ("child", false);
+    Predicate predicate = Predicate.NEQ("baseId", 0);

Review comment:
       what's the rational behind querying by baseId? Can you also include it in the code-comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] cecilynie commented on a change in pull request #5865: [TE] anomaly search - hide child anomaly unless queried with anomaly ids

Posted by GitBox <gi...@apache.org>.
cecilynie commented on a change in pull request #5865:
URL: https://github.com/apache/incubator-pinot/pull/5865#discussion_r470779043



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/anomalies/AnomalySearcher.java
##########
@@ -70,7 +70,11 @@ public AnomalySearcher() {
    * @return the result
    */
   public Map<String, Object> search(AnomalySearchFilter searchFilter, int limit, int offset) {
-    Predicate predicate = Predicate.EQ("child", false);
+    Predicate predicate = Predicate.NEQ("baseId", 0);

Review comment:
       Hi Jihao, is there a way for us to test the fix before waiting for the next deployment? This is a bit critical which is impacting all entity monitoring. Let's make sure it works when we deploy.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5865: [TE] anomaly search - hide child anomaly unless queried with anomaly ids

Posted by GitBox <gi...@apache.org>.
jihaozh commented on a change in pull request #5865:
URL: https://github.com/apache/incubator-pinot/pull/5865#discussion_r470810638



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/anomalies/AnomalySearcher.java
##########
@@ -70,7 +70,11 @@ public AnomalySearcher() {
    * @return the result
    */
   public Map<String, Object> search(AnomalySearchFilter searchFilter, int limit, int offset) {
-    Predicate predicate = Predicate.EQ("child", false);
+    Predicate predicate = Predicate.NEQ("baseId", 0);

Review comment:
       it will be tested by unit tests and staging before deploy.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] jihaozh merged pull request #5865: [TE] anomaly search - hide child anomaly unless queried with anomaly ids

Posted by GitBox <gi...@apache.org>.
jihaozh merged pull request #5865:
URL: https://github.com/apache/incubator-pinot/pull/5865


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org