You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/04 08:57:09 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1763: Avoid NPE in HandlerMappingRegistry
TeslaCN opened a new pull request #1763:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1763
Changes proposed in this pull request:
- Avoid NPE in HandlerMappingRegistry.
- Set initial content length for HTTP response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1763: Avoid NPE in HandlerMappingRegistry
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1763:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1763#issuecomment-738662347
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=h1) Report
> Merging [#1763](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=desc) (f35eb19) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/749c5a58b33c000db15518c46af3ce36f418cfcf?el=desc) (749c5a5) will **decrease** coverage by `0.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1763 +/- ##
============================================
- Coverage 86.07% 85.91% -0.17%
Complexity 109 109
============================================
Files 258 258
Lines 5781 5779 -2
Branches 889 889
============================================
- Hits 4976 4965 -11
- Misses 486 491 +5
- Partials 319 323 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/restful/handler/HandlerMappingRegistry.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9oYW5kbGVyL0hhbmRsZXJNYXBwaW5nUmVnaXN0cnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../pipeline/ContextInitializationInboundHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9Db250ZXh0SW5pdGlhbGl6YXRpb25JbmJvdW5kSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ener/AbstractDistributeOnceElasticJobListener.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvYXBpL2xpc3RlbmVyL0Fic3RyYWN0RGlzdHJpYnV0ZU9uY2VFbGFzdGljSm9iTGlzdGVuZXIuamF2YQ==) | `75.86% <0.00%> (-6.90%)` | `0.00% <0.00%> (ø%)` | |
| [.../elasticjob/restful/filter/DefaultFilterChain.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9maWx0ZXIvRGVmYXVsdEZpbHRlckNoYWluLmphdmE=) | `94.73% <0.00%> (-5.27%)` | `0.00% <0.00%> (ø%)` | |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
| [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `92.00% <0.00%> (-4.00%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=footer). Last update [749c5a5...f35eb19](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1763: Avoid NPE in HandlerMappingRegistry
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1763:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1763#issuecomment-738662347
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=h1) Report
> Merging [#1763](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=desc) (f35eb19) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/749c5a58b33c000db15518c46af3ce36f418cfcf?el=desc) (749c5a5) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1763 +/- ##
============================================
- Coverage 86.07% 86.05% -0.03%
Complexity 109 109
============================================
Files 258 258
Lines 5781 5779 -2
Branches 889 889
============================================
- Hits 4976 4973 -3
Misses 486 486
- Partials 319 320 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/restful/handler/HandlerMappingRegistry.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9oYW5kbGVyL0hhbmRsZXJNYXBwaW5nUmVnaXN0cnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../pipeline/ContextInitializationInboundHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9Db250ZXh0SW5pdGlhbGl6YXRpb25JbmJvdW5kSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../elasticjob/restful/filter/DefaultFilterChain.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9maWx0ZXIvRGVmYXVsdEZpbHRlckNoYWluLmphdmE=) | `94.73% <0.00%> (-5.27%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=footer). Last update [749c5a5...f35eb19](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1763?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- merged pull request #1763: Avoid NPE in HandlerMappingRegistry
Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1763:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1763
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org