You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/29 23:32:31 UTC
[GitHub] [spark] imback82 commented on a change in pull request #35056: [SPARK-37777][SQL] Update the SQL syntax of SHOW FUNCTIONS
imback82 commented on a change in pull request #35056:
URL: https://github.com/apache/spark/pull/35056#discussion_r776524589
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -2132,29 +2132,34 @@ class DDLParserSuite extends AnalysisTest {
}
test("SHOW FUNCTIONS") {
+ val nsPlan = UnresolvedNamespace(Nil)
comparePlans(
parsePlan("SHOW FUNCTIONS"),
- ShowFunctions(None, true, true, None))
+ ShowFunctions(nsPlan, true, true, None))
comparePlans(
parsePlan("SHOW USER FUNCTIONS"),
- ShowFunctions(None, true, false, None))
+ ShowFunctions(nsPlan, true, false, None))
comparePlans(
parsePlan("SHOW user FUNCTIONS"),
- ShowFunctions(None, true, false, None))
+ ShowFunctions(nsPlan, true, false, None))
comparePlans(
parsePlan("SHOW SYSTEM FUNCTIONS"),
- ShowFunctions(None, false, true, None))
+ ShowFunctions(nsPlan, false, true, None))
comparePlans(
parsePlan("SHOW ALL FUNCTIONS"),
- ShowFunctions(None, true, true, None))
+ ShowFunctions(nsPlan, true, true, None))
comparePlans(
parsePlan("SHOW FUNCTIONS LIKE 'funct*'"),
- ShowFunctions(None, true, true, Some("funct*")))
+ ShowFunctions(nsPlan, true, true, Some("funct*")))
+ comparePlans(
+ parsePlan("SHOW FUNCTIONS IN db LIKE 'funct*'"),
+ ShowFunctions(UnresolvedNamespace(Seq("db")), true, true, Some("funct*")))
comparePlans(
parsePlan("SHOW FUNCTIONS LIKE a.b.c"),
- ShowFunctions(Some(UnresolvedFunc(Seq("a", "b", "c"))), true, true, None))
+ ShowFunctions(UnresolvedNamespace(Seq("a", "b")), true, true, Some("c")))
val sql = "SHOW other FUNCTIONS"
intercept(sql, s"$sql not supported")
+ intercept("SHOW FUNCTIONS IN db f1", "Invalid pattern")
Review comment:
nit: add full error message?
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -2132,29 +2132,34 @@ class DDLParserSuite extends AnalysisTest {
}
test("SHOW FUNCTIONS") {
+ val nsPlan = UnresolvedNamespace(Nil)
comparePlans(
parsePlan("SHOW FUNCTIONS"),
- ShowFunctions(None, true, true, None))
+ ShowFunctions(nsPlan, true, true, None))
comparePlans(
parsePlan("SHOW USER FUNCTIONS"),
- ShowFunctions(None, true, false, None))
+ ShowFunctions(nsPlan, true, false, None))
comparePlans(
parsePlan("SHOW user FUNCTIONS"),
- ShowFunctions(None, true, false, None))
+ ShowFunctions(nsPlan, true, false, None))
comparePlans(
parsePlan("SHOW SYSTEM FUNCTIONS"),
- ShowFunctions(None, false, true, None))
+ ShowFunctions(nsPlan, false, true, None))
comparePlans(
parsePlan("SHOW ALL FUNCTIONS"),
- ShowFunctions(None, true, true, None))
+ ShowFunctions(nsPlan, true, true, None))
comparePlans(
parsePlan("SHOW FUNCTIONS LIKE 'funct*'"),
- ShowFunctions(None, true, true, Some("funct*")))
+ ShowFunctions(nsPlan, true, true, Some("funct*")))
+ comparePlans(
+ parsePlan("SHOW FUNCTIONS IN db LIKE 'funct*'"),
+ ShowFunctions(UnresolvedNamespace(Seq("db")), true, true, Some("funct*")))
comparePlans(
parsePlan("SHOW FUNCTIONS LIKE a.b.c"),
Review comment:
Can you add a test `SHOW FUNCTIONS LIKE a` so that namespace becomes `nsPlan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org