You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/04/27 10:52:00 UTC

[GitHub] [systemml] juliale-15 opened a new pull request #902: Modify Python API Testcases (rand, lm)

juliale-15 opened a new pull request #902:
URL: https://github.com/apache/systemml/pull/902


   Just a few changes to the testcase (increasing tolerance) so that the tc doesn't fail randomly.
   Remove mutiple definitions of run in python workflow file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemml] mboehm7 commented on pull request #902: Modify Python API Testcases (rand, lm)

Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #902:
URL: https://github.com/apache/systemml/pull/902#issuecomment-621483606


   Thanks for patch @juliale-15 and for the review @Baunsgaard 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemml] Baunsgaard commented on a change in pull request #902: Modify Python API Testcases (rand, lm)

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #902:
URL: https://github.com/apache/systemml/pull/902#discussion_r417366354



##########
File path: .github/workflows/python.yml
##########
@@ -74,9 +74,10 @@ jobs:
           ${{ runner.os }}-pip-${{ matrix.python-version }}-
   
     - name: Install pip Dependencies
-      run: pip install numpy py4j wheel
-      run: pip install scipy
-      run: pip install sklearn
+      run: |
+        pip install numpy py4j wheel
+        pip install scipy
+        pip install sklearn

Review comment:
       while merging change this to 
   
   `run: pip install numpy py4j wheel scipy sklean`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org