You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/22 15:52:51 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3161: Remove unnecessary Buffer::from_slice_ref reference
tustvold opened a new pull request, #3161:
URL: https://github.com/apache/arrow-rs/pull/3161
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The current interface can result in rather unhelpful errors - https://github.com/apache/arrow-rs/pull/3158#issuecomment-1323850323
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
Technically no, all previous uses will continue to work. However, clippy will complain about unnecessary borrows.
I ran the following to generate https://github.com/apache/arrow-rs/commit/c05ab2d1e04e2d0166aac4f432469247db80cbd6
```
cargo clippy --workspace --fix --all-targets
cargo fmt --all
```
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3161: Remove unnecessary Buffer::from_slice_ref reference
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3161:
URL: https://github.com/apache/arrow-rs/pull/3161#issuecomment-1324676433
Benchmark runs are scheduled for baseline = ca92306f801ca39372a4b4c8d9b4d430ead38f64 and contender = a6f140f79377eb02b4bec08177d940a3918c65d8. a6f140f79377eb02b4bec08177d940a3918c65d8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f16bc30b40ea42ab8c1eceb5d5ef8339...0f610cd5fe184f3d9d818bd9a166a853/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/49f5cde8227840f7bef9ea2411165cb9...ba9cca9684dd4e69942316c5ef1e0a0c/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ecb7b6db889d45dba82ec0e031965724...0fa0f88d24894d8e9bf1f934632131fa/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/10c20f4ad5b3444cb36fc31de12de14b...d4f8ae1e188a4fabacf378a3a6464e44/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3161: Remove unnecessary Buffer::from_slice_ref reference
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3161:
URL: https://github.com/apache/arrow-rs/pull/3161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org