You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/02/10 00:46:46 UTC
[GitHub] [submarine] liuxunorg opened a new pull request #176:
SUBMARINE-381. Temporarily disable the interpreter module
liuxunorg opened a new pull request #176: SUBMARINE-381. Temporarily disable the interpreter module
URL: https://github.com/apache/submarine/pull/176
### What is this PR for?
1. Temporarily disable the interpreter module
submarine currently depends the zeppelin-0.9.0-SNAPSHORT version of the interpreter,
Perform python syntax execution.
As zeppelin is ready to officially release version 0.9, the zeppelin-0.9.0-SNAPSHORT version of the interpreter has been removed from the apache mvn repo.
Therefore, the submarine needs to temporarily block the submarine-interpreter. Otherwise, in travis, it will fail because it cannot download the zeppelin-0.9.0-SNAPSHORT interpreter.
After zeppelin 0.9 is released, it will be reintroduced.
2. Fixed travis failure problem
### What type of PR is it?
[Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/SUBMARINE-381
### How should this be tested?
* https://travis-ci.org/liuxunorg/submarine/builds/648053292
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #176:
SUBMARINE-381. Temporarily disable interpreter module
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #176: SUBMARINE-381. Temporarily disable interpreter module
URL: https://github.com/apache/submarine/pull/176#discussion_r376852849
##########
File path: bin/submarine-daemon.sh
##########
@@ -39,7 +39,6 @@ SUBMARINE_SERVER_MAIN=org.apache.submarine.server.SubmarineServer
JAVA_OPTS+="${SUBMARINE_SERVER_JAVA_OPTS} ${SUBMARINE_SERVER_MEM} -Dsubmarine.log.file=${SUBMARINE_SERVER_LOGFILE}"
add_jar_in_dir "${BIN}/../lib"
-add_jar_in_dir "${BIN}/../lib/submitter"
Review comment:
This is used to fix jar conflicts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #176: SUBMARINE-381.
Temporarily disable interpreter module
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #176: SUBMARINE-381. Temporarily disable interpreter module
URL: https://github.com/apache/submarine/pull/176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #176: SUBMARINE-381.
Temporarily disable interpreter module
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #176: SUBMARINE-381. Temporarily disable interpreter module
URL: https://github.com/apache/submarine/pull/176#issuecomment-583941193
Will merge if no more comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] tangzhankun commented on issue #176: SUBMARINE-381.
Temporarily disable interpreter module
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on issue #176: SUBMARINE-381. Temporarily disable interpreter module
URL: https://github.com/apache/submarine/pull/176#issuecomment-583936326
Thanks a lot for the quick fix. @liuxunorg +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #176:
SUBMARINE-381. Temporarily disable interpreter module
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #176: SUBMARINE-381. Temporarily disable interpreter module
URL: https://github.com/apache/submarine/pull/176#discussion_r376853898
##########
File path: bin/submarine-daemon.sh
##########
@@ -39,7 +39,6 @@ SUBMARINE_SERVER_MAIN=org.apache.submarine.server.SubmarineServer
JAVA_OPTS+="${SUBMARINE_SERVER_JAVA_OPTS} ${SUBMARINE_SERVER_MEM} -Dsubmarine.log.file=${SUBMARINE_SERVER_LOGFILE}"
add_jar_in_dir "${BIN}/../lib"
-add_jar_in_dir "${BIN}/../lib/submitter"
Review comment:
No, this is an invalid code.
Because the submitter is loaded dynamically at runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org