You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2022/04/07 09:57:11 UTC
[GitHub] [qpid-proton] Jmennius opened a new pull request, #364: NO-JIRA: [Python] Fix exception in IOHandler.on_selectable_expired/update
Jmennius opened a new pull request, #364:
URL: https://github.com/apache/qpid-proton/pull/364
This occasionally happens after my laptop wakes up from overnight sleep.
IOHandler.on_selectable_expired() is invoked with `selectable` that has
`_terminated=True` and `_transport=None` so when `IOHandler.update()`
is called it crashes when trying to handle the exception
(since transport is None).
Fix this by checking if transport attribute is set and that selectable is not
terminated before invoking `IOHandler.update()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] NO-JIRA: [Python] Fix exception in IOHandler.on_selectable_expired/update [qpid-proton]
Posted by "itechbear (via GitHub)" <gi...@apache.org>.
itechbear commented on PR #364:
URL: https://github.com/apache/qpid-proton/pull/364#issuecomment-1817766166
Could we get this PR merged? I ran into the bug recently. It causes qpid proton to be pretty unusable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] Jmennius commented on pull request #364: NO-JIRA: [Python] Fix exception in IOHandler.on_selectable_expired/update
Posted by GitBox <gi...@apache.org>.
Jmennius commented on PR #364:
URL: https://github.com/apache/qpid-proton/pull/364#issuecomment-1099143646
Here is a traceback:
```
Traceback (most recent call last):
File "/path/.venv/lib/python3.7/site-packages/proton/_handlers.py", line 1293, in update
capacity = transport.capacity()
AttributeError: 'NoneType' object has no attribute 'capacity'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/path/my-project.py", line 285, in run
self.container.run()
File "/path/.venv/lib/python3.7/site-packages/proton/_reactor.py", line 197, in run
while self.process():
File "/path/.venv/lib/python3.7/site-packages/proton/_reactor.py", line 262, in process
event.dispatch(self._global_handler)
File "/path/.venv/lib/python3.7/site-packages/proton/_events.py", line 158, in dispatch
_dispatch(handler, type.method, self)
File "/path/.venv/lib/python3.7/site-packages/proton/_events.py", line 131, in _dispatch
handler.on_unhandled(method, *args)
File "/path/.venv/lib/python3.7/site-packages/proton/_reactor.py", line 905, in on_unhandled
event.dispatch(self.base)
File "/path/.venv/lib/python3.7/site-packages/proton/_events.py", line 158, in dispatch
_dispatch(handler, type.method, self)
File "/path/.venv/lib/python3.7/site-packages/proton/_events.py", line 129, in _dispatch
m(*args)
File "/path/.venv/lib/python3.7/site-packages/proton/_handlers.py", line 1237, in on_selectable_expired
self.update(t, s, r.now)
File "/path/.venv/lib/python3.7/site-packages/proton/_handlers.py", line 1296, in update
if transport.closed:
AttributeError: 'NoneType' object has no attribute 'closed'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] Jmennius commented on pull request #364: NO-JIRA: [Python] Fix exception in IOHandler.on_selectable_expired/update
Posted by GitBox <gi...@apache.org>.
Jmennius commented on PR #364:
URL: https://github.com/apache/qpid-proton/pull/364#issuecomment-1118866667
@astitcher What do you think?
Should I open an issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter commented on pull request #364: NO-JIRA: [Python] Fix exception in IOHandler.on_selectable_expired/update
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #364:
URL: https://github.com/apache/qpid-proton/pull/364#issuecomment-1114534186
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#364](https://codecov.io/gh/apache/qpid-proton/pull/364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4d22a80) into [main](https://codecov.io/gh/apache/qpid-proton/commit/a920192ab29e2845134fd340bf230f223f837243?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a920192) will **decrease** coverage by `3.90%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #364 +/- ##
==========================================
- Coverage 68.24% 64.33% -3.91%
==========================================
Files 367 46 -321
Lines 73285 2344 -70941
==========================================
- Hits 50011 1508 -48503
+ Misses 23274 836 -22438
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [ruby/lib/core/container.rb](https://codecov.io/gh/apache/qpid-proton/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb250YWluZXIucmI=) | `27.35% <0.00%> (-71.75%)` | :arrow_down: |
| [ruby/lib/handler/reactor\_messaging\_adapter.rb](https://codecov.io/gh/apache/qpid-proton/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9yZWFjdG9yX21lc3NhZ2luZ19hZGFwdGVyLnJi) | `32.55% <0.00%> (-58.14%)` | :arrow_down: |
| [ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==) | `46.08% <0.00%> (-50.01%)` | :arrow_down: |
| [ruby/lib/core/work\_queue.rb](https://codecov.io/gh/apache/qpid-proton/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS93b3JrX3F1ZXVlLnJi) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [ruby/lib/core/uri.rb](https://codecov.io/gh/apache/qpid-proton/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS91cmkucmI=) | `56.66% <0.00%> (-43.34%)` | :arrow_down: |
| [ruby/lib/util/schedule.rb](https://codecov.io/gh/apache/qpid-proton/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9zY2hlZHVsZS5yYg==) | `61.90% <0.00%> (-38.10%)` | :arrow_down: |
| [ruby/lib/core/delivery.rb](https://codecov.io/gh/apache/qpid-proton/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9kZWxpdmVyeS5yYg==) | `57.57% <0.00%> (-36.37%)` | :arrow_down: |
| [ruby/lib/handler/messaging\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9tZXNzYWdpbmdfaGFuZGxlci5yYg==) | `57.14% <0.00%> (-35.72%)` | :arrow_down: |
| [ruby/lib/core/tracker.rb](https://codecov.io/gh/apache/qpid-proton/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS90cmFja2VyLnJi) | `55.55% <0.00%> (-33.34%)` | :arrow_down: |
| [ruby/lib/core/connection.rb](https://codecov.io/gh/apache/qpid-proton/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb25uZWN0aW9uLnJi) | `60.00% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [337 more](https://codecov.io/gh/apache/qpid-proton/pull/364/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/364?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a920192...4d22a80](https://codecov.io/gh/apache/qpid-proton/pull/364?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] NO-JIRA: [Python] Fix exception in IOHandler.on_selectable_expired/update [qpid-proton]
Posted by "Jmennius (via GitHub)" <gi...@apache.org>.
Jmennius commented on PR #364:
URL: https://github.com/apache/qpid-proton/pull/364#issuecomment-1818736158
I've opened a Jira issue for this https://issues.apache.org/jira/browse/PROTON-2776.
I can work on the PR if ncessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org