You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/12 12:28:47 UTC

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3525: Fix stm32f7 protected build

davids5 commented on a change in pull request #3525:
URL: https://github.com/apache/incubator-nuttx/pull/3525#discussion_r611583314



##########
File path: arch/arm/src/stm32f7/stm32_allocateheap.c
##########
@@ -328,35 +337,19 @@ void up_allocate_heap(FAR void **heap_start, size_t *heap_size)
 #if defined(CONFIG_BUILD_PROTECTED) && defined(CONFIG_MM_KERNEL_HEAP)
 void up_allocate_kheap(FAR void **heap_start, size_t *heap_size)
 {
-  /* Get the unaligned size and position of the user-space heap.
-   * This heap begins after the user-space .bss section at an offset
-   * of CONFIG_MM_KERNEL_HEAPSIZE (subject to alignment).
+  /* User heap was just initialized in nx_start, store the user heap

Review comment:
       ```suggestion
     /* User heap was just initialized, with proper MPU alignment, in nx_start, store the user heap
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org