You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/03/27 00:54:15 UTC
Review Request 32555: Fixed the rate limiting of slave removals during
master recovery.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32555/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-2392
https://issues.apache.org/jira/browse/MESOS-2392
Repository: mesos
Description
-------
When we adding rate limiting of recovered slave removals, the metric logic was buggy in that it reports all of the recovered slaves as having been scheduled for removal. It also unnecessarily acquires rate limiting tokens.
Diffs
-----
src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
Diff: https://reviews.apache.org/r/32555/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 32555: Fixed the rate limiting of slave removals
during master recovery.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32555/#review77980
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 26, 2015, 11:54 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32555/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 11:54 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-2392
> https://issues.apache.org/jira/browse/MESOS-2392
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When we adding rate limiting of recovered slave removals, the metric logic was buggy in that it reports all of the recovered slaves as having been scheduled for removal. It also unnecessarily acquires rate limiting tokens.
>
>
> Diffs
> -----
>
> src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
>
> Diff: https://reviews.apache.org/r/32555/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>