[GitHub] wonook edited a comment on issue #103: [NEMO-11] Generalize Equality of Int Predicates for Loops

[GitBox <gi...@apache.org>]

wonook edited a comment on issue #103: [NEMO-11] Generalize Equality of Int Predicates for Loops
URL: https://github.com/apache/incubator-nemo/pull/103#issuecomment-413768100
 
 
   Hi @arunlakshman, sorry for my late review, I'm currently on holiday for the moment.
   Refactoring the code into a util package is definitely a good direction, and changing the recursive logic to an iterative logic can make it easier for readers to perceive the code. One concern is that although it's in a good direction, it doesn't completely solve the issue. There are some missing details in the issue description (my bad), but the issue expects a more sophisticated algorithm that provides a general way to check the equality between the int predicates, instead of having to provide the range of numbers manually. Maybe we could leave the `noOfTimes` parameter as a minimum range to check, and add a bit of a logic that checks the boundaries up to a point a particular predicate changes from true to false, or the other way around and check the equality of both predicates at that boundary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services