You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/25 21:56:47 UTC
[GitHub] [beam] AnandInguva opened a new pull request, #17460: Change return type for PytorchInferenceRunner
AnandInguva opened a new pull request, #17460:
URL: https://github.com/apache/beam/pull/17460
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged PR #17460:
URL: https://github.com/apache/beam/pull/17460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #17460:
URL: https://github.com/apache/beam/pull/17460#discussion_r858066116
##########
sdks/python/apache_beam/ml/inference/pytorch.py:
##########
@@ -37,7 +37,7 @@ def __init__(self, device: torch.device):
self._device = device
def run_inference(self, batch: List[torch.Tensor],
- model: torch.nn.Module) -> Iterable[torch.Tensor]:
+ model: torch.nn.Module) -> Iterable[PredictionResult]:
"""
Review Comment:
If the contract is that this should produce an iterable, I wonder if we should avoid materializing the list by returning a generator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #17460:
URL: https://github.com/apache/beam/pull/17460#discussion_r858073801
##########
sdks/python/apache_beam/ml/inference/pytorch.py:
##########
@@ -37,7 +37,7 @@ def __init__(self, device: torch.device):
self._device = device
def run_inference(self, batch: List[torch.Tensor],
- model: torch.nn.Module) -> Iterable[torch.Tensor]:
+ model: torch.nn.Module) -> Iterable[PredictionResult]:
"""
Review Comment:
I think its done in the later stage in a DoFn
https://github.com/apache/beam/blob/68b9100db4b82196eba025bd417c46d03656f7c0/sdks/python/apache_beam/ml/inference/base.py#L210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17460:
URL: https://github.com/apache/beam/pull/17460#issuecomment-1109092702
# [Codecov](https://codecov.io/gh/apache/beam/pull/17460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17460](https://codecov.io/gh/apache/beam/pull/17460?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2874b3e) into [master](https://codecov.io/gh/apache/beam/commit/68b9100db4b82196eba025bd417c46d03656f7c0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68b9100) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17460 +/- ##
==========================================
- Coverage 73.93% 73.92% -0.01%
==========================================
Files 689 689
Lines 90397 90397
==========================================
- Hits 66835 66829 -6
- Misses 22378 22384 +6
Partials 1184 1184
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.65% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/17460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/17460/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `87.80% <0.00%> (-7.32%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/17460/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `87.50% <0.00%> (-1.71%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/17460/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.47% <0.00%> (-0.78%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/17460/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.03% <0.00%> (-0.39%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/17460/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `90.18% <0.00%> (-0.31%)` | :arrow_down: |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/17460/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `93.08% <0.00%> (+0.64%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/17460/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `89.40% <0.00%> (+1.38%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17460?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17460?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68b9100...2874b3e](https://codecov.io/gh/apache/beam/pull/17460?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #17460:
URL: https://github.com/apache/beam/pull/17460#issuecomment-1109082705
CC: @tvalentyn @TheNeuralBit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #17460:
URL: https://github.com/apache/beam/pull/17460#discussion_r858086986
##########
sdks/python/apache_beam/ml/inference/pytorch.py:
##########
@@ -37,7 +37,7 @@ def __init__(self, device: torch.device):
self._device = device
def run_inference(self, batch: List[torch.Tensor],
- model: torch.nn.Module) -> Iterable[torch.Tensor]:
+ model: torch.nn.Module) -> Iterable[PredictionResult]:
"""
Review Comment:
Ah got it. For my understanding, using a generator takes less memory right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #17460:
URL: https://github.com/apache/beam/pull/17460#discussion_r858086986
##########
sdks/python/apache_beam/ml/inference/pytorch.py:
##########
@@ -37,7 +37,7 @@ def __init__(self, device: torch.device):
self._device = device
def run_inference(self, batch: List[torch.Tensor],
- model: torch.nn.Module) -> Iterable[torch.Tensor]:
+ model: torch.nn.Module) -> Iterable[PredictionResult]:
"""
Review Comment:
Ah got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17460:
URL: https://github.com/apache/beam/pull/17460#issuecomment-1109080135
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #17460:
URL: https://github.com/apache/beam/pull/17460#discussion_r858084738
##########
sdks/python/apache_beam/ml/inference/pytorch.py:
##########
@@ -37,7 +37,7 @@ def __init__(self, device: torch.device):
self._device = device
def run_inference(self, batch: List[torch.Tensor],
- model: torch.nn.Module) -> Iterable[torch.Tensor]:
+ model: torch.nn.Module) -> Iterable[PredictionResult]:
"""
Review Comment:
What I'm suggesting is that we could avoid materializing a list between here and there by returning a generator (`(PredictionResult(x, y) for x, y in zip(batch, predictions))`) here. It looks like that would be undermined by the base DoFn materializing a list again here anyway: https://github.com/apache/beam/blob/68b9100db4b82196eba025bd417c46d03656f7c0/sdks/python/apache_beam/ml/inference/base.py#L198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17460:
URL: https://github.com/apache/beam/pull/17460#issuecomment-1109080130
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #17460:
URL: https://github.com/apache/beam/pull/17460#issuecomment-1109080595
R: @yeandy @ryanthompson591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #17460: Change return type for PytorchInferenceRunner
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #17460:
URL: https://github.com/apache/beam/pull/17460#discussion_r858086986
##########
sdks/python/apache_beam/ml/inference/pytorch.py:
##########
@@ -37,7 +37,7 @@ def __init__(self, device: torch.device):
self._device = device
def run_inference(self, batch: List[torch.Tensor],
- model: torch.nn.Module) -> Iterable[torch.Tensor]:
+ model: torch.nn.Module) -> Iterable[PredictionResult]:
"""
Review Comment:
Ah got it. For my understanding, using a generator takes less memory right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org