You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "tbw777 (via GitHub)" <gi...@apache.org> on 2023/02/02 17:44:13 UTC
[GitHub] [netbeans] tbw777 opened a new pull request, #5413: Cleanup: removed dead/unused private methods. Part 1
tbw777 opened a new pull request, #5413:
URL: https://github.com/apache/netbeans/pull/5413
Methods excluded throught commenting, no other types of changing are made. After was excluded unused methods layer 1 there is next level unused methods was found that also exluded. This type of changing is simple to review therefore contains a lot of diffs. Its not automated change!
Profits:
- less IDE indexer load
- resulting version size
- JVM method search speed and memory usage
- less compile time
- improved code navigation if parent methods will searching (unused parents excluded)
- less overall % of methods without tests coverage
- less Strings pool size of literals
Excuse me for size. Its about 50% coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5413: Cleanup: removed dead/unused private methods. Part 1
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5413:
URL: https://github.com/apache/netbeans/pull/5413#issuecomment-1414421737
Could you split the commit somewhat ? For example one commit per cluster ? It could be easier to review.
Please note that while removing dead code is good, we must be more careful in Platform or IDE clusters - it's possible that some other module hacked into the implementation using Reflection. It should not been done in the first place, I agree completely ... but this kind of ... things... happens in such long-lived codebase.
So please let's be careful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5413: Cleanup: removed dead/unused private methods. Part 1
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5413:
URL: https://github.com/apache/netbeans/pull/5413#issuecomment-1416141536
new PRs in #5420 and other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5413: Cleanup: removed dead/unused private methods. Part 1
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5413:
URL: https://github.com/apache/netbeans/pull/5413#issuecomment-1415029093
Of course. For example i can split per parent dir.
>For example one commit per cluster ?
What do you mean? Explain please.
>it's possible that some other module hacked into the implementation using Reflection.
You are right, ANT can call private methods also. Nightmare.
You can mark this PR do no merge, i can create splitted versions later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 closed pull request #5413: Cleanup: removed dead/unused private methods. Part 1
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 closed pull request #5413: Cleanup: removed dead/unused private methods. Part 1
URL: https://github.com/apache/netbeans/pull/5413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists