[GitHub] [pinot] abhs50 commented on a diff in pull request #8907: Log Request header for Broker

[GitBox <gi...@apache.org>]

abhs50 commented on code in PR #8907:
URL: https://github.com/apache/pinot/pull/8907#discussion_r899419574


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -682,7 +685,9 @@ private void logBrokerResponse(long requestId, String query, RequestContext requ
           brokerResponse.getOfflineThreadCpuTimeNs(), brokerResponse.getOfflineSystemActivitiesCpuTimeNs(),
           brokerResponse.getOfflineResponseSerializationCpuTimeNs(), brokerResponse.getRealtimeTotalCpuTimeNs(),
           brokerResponse.getRealtimeThreadCpuTimeNs(), brokerResponse.getRealtimeSystemActivitiesCpuTimeNs(),
-          brokerResponse.getRealtimeResponseSerializationCpuTimeNs(), StringUtils.substring(query, 0, _queryLogLength));
+          brokerResponse.getRealtimeResponseSerializationCpuTimeNs(),
+          ((HttpRequesterIdentity) requesterIdentity).getHttpHeaders().toString(),

Review Comment:
   I agree.  Hence the comment here: https://github.com/apache/pinot/issues/8869#issuecomment-1157729246
   
   Wanted to see what the community feels about this. If we have specific keys then it may only solve for certain set of use cases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org