You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by boliza <gi...@git.apache.org> on 2017/10/03 14:48:44 UTC

[GitHub] tinkerpop pull request #727: add three missing config in Driver Settings

GitHub user boliza opened a pull request:

    https://github.com/apache/tinkerpop/pull/727

    add three missing config in Driver Settings

    The configs is:
    1. keyCertChainFile
    2. keyFile
    3. keyPassword

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/boliza/tinkerpop add_missing_config

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/727.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #727
    
----
commit 3cdaaea5ee192b1875dd86217f864d30df287243
Author: Ranger Tsao <ca...@gmail.com>
Date:   2017-10-03T14:44:12Z

    add three missing config
    
    1. keyCertChainFile
    2. keyFile
    3. keyPassword

----


---

[GitHub] tinkerpop issue #727: TINKERPOP-1796: Driver connection pool SSL properties ...

Posted by robertdale <gi...@git.apache.org>.

Github user robertdale commented on the issue:

    https://github.com/apache/tinkerpop/pull/727
  
    Thanks.
    VOTE +1



---

[GitHub] tinkerpop issue #727: TINKERPOP-1796: Driver connection pool SSL properties ...

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/727
  
    VOTE: +1


---

[GitHub] tinkerpop issue #727: TINKERPOP-1796: Driver connection pool SSL properties ...

Posted by boliza <gi...@git.apache.org>.

Github user boliza commented on the issue:

    https://github.com/apache/tinkerpop/pull/727
  
    @robertdale done.


---

[GitHub] tinkerpop issue #727: add three missing config in Driver Settings

Posted by robertdale <gi...@git.apache.org>.

Github user robertdale commented on the issue:

    https://github.com/apache/tinkerpop/pull/727
  
    @boliza I created a JIRA issue. Please review it. Can you change the title to include 'TINKERPOP-1796' and put the link 'https://issues.apache.org/jira/browse/TINKERPOP-1796' in the first comment?


---

[GitHub] tinkerpop pull request #727: TINKERPOP-1796: Driver connection pool SSL prop...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/727


---

[GitHub] tinkerpop issue #727: TINKERPOP-1796: Driver connection pool SSL properties ...

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/727
  
    Good fix - VOTE +1


---